-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mariadb: allow mysqld to set max_connections at startup #86
base: main
Are you sure you want to change the base?
Conversation
Mariadb pods are started as user mysql, which has no specific right to configure file descriptor limits. This prevents the server from honoring the requested max_connections of 4096. Make the pod start mysqld as root, and let the mysqld server drop privileges to user mysql explicitly. This way, the server can configure limits prior to accepting connections.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dciabrin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We agreed that this is a temporary solution until we switch to galera by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test mariadb-operator-build-deploy-kuttl |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dciabrin want to rebase? |
@dciabrin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mariadb pods are started as user mysql, which has no specific right to configure file descriptor limits. This prevents the server from honoring the requested max_connections of 4096.
Make the pod start mysqld as root, and let the mysqld server drop privileges to user mysql explicitly. This way, the server can configure limits prior to accepting connections.