Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kuttl job #14

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add kuttl job #14

wants to merge 1 commit into from
+24 −1

Conversation

cescgina
Copy link
Contributor

@cescgina cescgina commented Nov 26, 2024 •
edited
Loading

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cescgina. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/watcher-operator on branch main. The
problem was:

Invalid Ansible variable name 'operator-name' for dictionary value @ data['vars']

The problem appears in the the "watcher-operator-kuttl" job stanza:

job:
name: watcher-operator-kuttl
parent: cifmw-multinode-kuttl-operator-target
vars:
operator-name: watcher-operator
cifmw_target_hook_host: controller
pre-run:
# TODO: this hook also deploys watcher, which is probably not good for
# kuttl
...

in "openstack-k8s-operators/watcher-operator/.zuul.yaml@main", line 41

@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/watcher-operator on branch main. The
problem was:

Invalid Ansible variable name 'operator-name' for dictionary value @ data['vars']

The problem appears in the the "watcher-operator-kuttl" job stanza:

job:
name: watcher-operator-kuttl
parent: cifmw-multinode-kuttl-operator-target
vars:
operator-name: watcher-operator
cifmw_target_hook_host: controller
pre-run:
# TODO: this hook also deploys watcher, which is probably not good for
# kuttl
...

in "openstack-k8s-operators/watcher-operator/.zuul.yaml@main", line 41

@cescgina cescgina force-pushed the add_kuttl_job branch 2 times, most recently from 99b544e to 3c13ae3 Compare November 26, 2024 15:37
@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c09b642cdeb5486c97c2bd314adbbe99

✔️ openstack-meta-content-provider SUCCESS in 1h 24m 27s
✔️ watcher-operator-validation SUCCESS in 1h 14m 03s
❌ watcher-operator-kuttl RETRY_LIMIT in 13m 51s

@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2571 is needed.

@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2571 is needed.

@cescgina
Copy link
Contributor Author

recheck

1 similar comment
@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2571 is needed.

@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2571 is needed.

@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/db40ad3c91cc447fa330e0033dc8c9ad

✔️ openstack-meta-content-provider SUCCESS in 1h 29m 35s
✔️ watcher-operator-validation SUCCESS in 1h 12m 24s
❌ watcher-operator-kuttl RETRY_LIMIT in 35m 33s

@cescgina cescgina force-pushed the add_kuttl_job branch 2 times, most recently from 343bb38 to 693d9a4 Compare November 27, 2024 16:28
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2571 is needed.

@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/da4988751aba41a4a4aef3db144245f6

✔️ openstack-meta-content-provider SUCCESS in 1h 24m 53s
✔️ watcher-operator-validation SUCCESS in 1h 13m 38s
❌ watcher-operator-kuttl RETRY_LIMIT in 51m 26s

@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2571 is needed.

@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2571 is needed.

@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bb16d65ff2d84da89ff535a95855288a

✔️ openstack-meta-content-provider SUCCESS in 1h 25m 42s
✔️ watcher-operator-validation SUCCESS in 1h 13m 05s
❌ watcher-operator-kuttl FAILURE in 41m 38s

cescgina added a commit to cescgina/watcher-operator that referenced this pull request Nov 28, 2024
@cescgina
Add secret to controller rbac
9d3d55d 
While trying to run kuttl tests in [1], we get an error [2]
stating that the watcher controller does not have access to secrets.
This change adds the required kubebuilder annotations for secrets in the
watcher controller.

[1] openstack-k8s-operators#14
[2] https://logserver.rdoproject.org/14/14/693d9a4c2c6b2630ef004bcd34b0bf3076826174/github-check/watcher-operator-kuttl/12efc41/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack-operators/pods/watcher-operator-controller-manager-84c899877f-wjsx8/logs/manager.log # Please enter the commit message for your changes. Lines starting
@cescgina cescgina mentioned this pull request Nov 28, 2024
Merged
@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/25eb612a912947c085c064b669159fa0

✔️ openstack-meta-content-provider SUCCESS in 1h 27m 33s
✔️ watcher-operator-validation SUCCESS in 1h 14m 26s
❌ watcher-operator-kuttl FAILURE in 42m 25s

cescgina added a commit to cescgina/watcher-operator that referenced this pull request Nov 28, 2024
@cescgina
Add secret and services to controller rbac
d699c63 
While trying to run kuttl tests in [1], we get an error [2]
stating that the watcher controller does not have access to secrets.
This change adds the required kubebuilder annotations for secrets in the
watcher controller. Similarly, we are also missing access to services
[3].

[1] openstack-k8s-operators#14
[2] https://logserver.rdoproject.org/14/14/693d9a4c2c6b2630ef004bcd34b0bf3076826174/github-check/watcher-operator-kuttl/12efc41/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack-operators/pods/watcher-operator-controller-manager-84c899877f-wjsx8/logs/manager.log # Please enter the commit message for your changes. Lines starting
[3] https://logserver.rdoproject.org/14/14/693d9a4c2c6b2630ef004bcd34b0bf3076826174/github-check/watcher-operator-kuttl/1968261/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack-operators/pods/watcher-operator-controller-manager-67dbb9c5d5-t25z6/logs/manager.log
@cescgina
Copy link
Contributor Author

recheck

@cescgina cescgina mentioned this pull request Nov 28, 2024
Open
@cescgina
Add kuttl job for watcher-operator
5340526 
This job uses a parent job defined in [1] based on the existing
nova-operator.

[1] openstack-k8s-operators/ci-framework#2571
@cescgina cescgina changed the title [WIP] Add kuttl job Add kuttl job Nov 28, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2571 is needed.

@cescgina
Copy link
Contributor Author

recheck

openshift-merge-bot bot pushed a commit that referenced this pull request Nov 29, 2024
@cescgina @openshift-merge-bot
Add secret and services to controller rbac
011339a 
While trying to run kuttl tests in [1], we get an error [2]
stating that the watcher controller does not have access to secrets.
This change adds the required kubebuilder annotations for secrets in the
watcher controller. Similarly, we are also missing access to services
[3].

[1] #14
[2] https://logserver.rdoproject.org/14/14/693d9a4c2c6b2630ef004bcd34b0bf3076826174/github-check/watcher-operator-kuttl/12efc41/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack-operators/pods/watcher-operator-controller-manager-84c899877f-wjsx8/logs/manager.log # Please enter the commit message for your changes. Lines starting
[3] https://logserver.rdoproject.org/14/14/693d9a4c2c6b2630ef004bcd34b0bf3076826174/github-check/watcher-operator-kuttl/1968261/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack-operators/pods/watcher-operator-controller-manager-67dbb9c5d5-t25z6/logs/manager.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cescgina