Tags not working

[nickw108]

I recently noticed that the tags in this fork seem to point to Magento2_German_LocalePack_de_DE and when you install the fork via composer as per the README, the language pack does not work, at least with composer require openstream/mage2-locale-de-ch. I've therefore been installing it manually by copying the files, but that's sort of annoying.

I've been updating tags as outlined in the README, but that doesn't seem to work. I'm not an advanced git user, so maybe someone who uses this repository with composer has any tricks to still make it work? Otherwise I would think I have to try to rebase as described in this StackOverflow question?

[heldchen]

we're using the following composer patches:

diff --git a/language.xml b/language.xml
index ea93591e7a..c463dedc50 100644
--- a/language.xml
+++ b/language.xml
@@ -6,7 +6,8 @@
  */
 -->
 <language xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:App/Language/package.xsd">
     <code>de_DE</code>
-    <vendor>splendid</vendor>
-    <package>de_de</package>
+    <vendor>openstream</vendor>
+    <package>de_ch</package>
+    <sort_order>1</sort_order>
 </language>

diff --git a/registration.php b/registration.php
index 2f8d1b4751..6ea17d53c1 100644
--- a/registration.php
+++ b/registration.php
@@ -6,6 +6,6 @@
 
 \Magento\Framework\Component\ComponentRegistrar::register(
     \Magento\Framework\Component\ComponentRegistrar::LANGUAGE,
-    'splendid_de_de',
+    'openstream_de_ch',
     __DIR__
 );

diff --git a/composer.json b/composer.json
index 42faac09da..2df5ddadce 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
 {
-    "name": "splendidinternet/mage2-locale-de-de",
-    "description": "German (Germany) language",
+    "name": "openstream/mage2-locale-de-ch",
+    "description": "German (Switzerland) language",
     "license": [
         "OSL-3.0"
     ],

the last one is just to calm my ocd tho :)

maybe these patches could be automatically applied to the fork somehow? in any case, would be nice to have a fully working composer version of this fork.

[nickw108]

Thanks for your feedback. I'm not sure how to apply these changes to the tags. They are in master (in this fork), but as soon as you switch to the tag, they're not there anymore.

[heldchen]

ah I see. the releases zip files are based on the upstream tags. understood the problem now.

maybe the new github actions could be used to re-create the tags on the fork with the proper changes when an upstream tag is created? I'm not an experienced github user tho, so not sure if that would be possible.