Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timestamp conform to https://tools.ietf.org/html/draft-ietf-payload-rtp-opus-11 #38

Open
Jeyhey opened this issue Aug 5, 2016 · 0 comments

Comments

@Jeyhey
Copy link

Jeyhey commented Aug 5, 2016

Just a hint: According to https://tools.ietf.org/html/draft-ietf-payload-rtp-opus-11 page 6 paragraph 4, for OPUS the timestamp has to be increased by 960 every frame regardless of the frame-size and sample rate. You can easily implement it by introducing in RtpStreamSender on line 568 the following two lines:

else if (p_type.codec.number() == 98) 
                time += 960;

This will make lumicall compatible with webRTC ; ). Otherwise the voice will be strange on the webRTC side.
(By the way webRTC uses the number 111 for opus).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant