Reverse the order of the arguments of assertEquals #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpocock
reviewed
Jul 18, 2018
| @@ -0,0 +1,27 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
please don't include the .classpath file in your commit, it is only for Eclipse
dpocock
reviewed
Jul 18, 2018
| @@ -48,8 +48,7 @@ public void test2() { | |||
| TelCandidateHarvester h2 = new TelCandidateHarvester(); | |||
| h2.addListener(t2); | |||
| String number = "9971pranav"; | |||
| System.out.println(" first print test2:"+number); | |||
| System.out.println(" second print test2:"+number); | |||
| System.out.println("print test2:"+number); | |||
There was a problem hiding this comment.
instead of System.out.println, could you use slf4j?
|
Thanks Daniel for the suggestion.
2018-07-18 10:13 GMT+02:00 Daniel Pocock <[email protected]>:
… ***@***.**** commented on this pull request.
------------------------------
In core/src/test/java/org/omnidial/harvest/TelCandidateHarvesterTest.java
<#3 (comment)>
:
> @@ -48,8 +48,7 @@ public void test2() {
TelCandidateHarvester h2 = new TelCandidateHarvester();
h2.addListener(t2);
String number = "9971pranav";
- System.out.println(" first print test2:"+number);
- System.out.println(" second print test2:"+number);
+ System.out.println("print test2:"+number);
instead of System.out.println, could you use slf4j?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Aj-Ex5OJk83LEZlBaCOQFH7C2r1VezzNks5uHu4UgaJpZM4VN29x>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.