Enhances tests according to changes (#45)

Author: ibraheem-opentensor

.github/workflows/e2e-subtensor-tests.yml

@@ -64,8 +64,8 @@ jobs:
         run: git checkout testnet
 
       - name: Install Python dependencies
-        run: python3 -m pip install -r requirements.txt pytest
+        run: python3 -m pip install -e . pytest
 
       - name: Run all tests
         run: |
-          LOCALNET_SH_PATH="${{ github.workspace }}/subtensor/scripts/localnet.sh" pytest src/tests/e2e_tests -s
+          LOCALNET_SH_PATH="${{ github.workspace }}/subtensor/scripts/localnet.sh" pytest tests/e2e_tests -s

tests/e2e_tests/__init__.py

@@ -2,16 +2,18 @@
 import os
 import re
 import shlex
+import shutil
 import signal
 import subprocess
 import time
 
 import pytest
-
 from bittensor_cli.src.bittensor.async_substrate_interface import (
     AsyncSubstrateInterface,
 )
 
+from .utils import setup_wallet
+
 
 # Fixture for setting up and tearing down a localnet.sh chain between tests
 @pytest.fixture(scope="function")
@@ -70,3 +72,19 @@ def wait_for_node_start(process, pattern):
 
     # Ensure the process has terminated
     process.wait()
+
+
+@pytest.fixture(scope="function")
+def wallet_setup():
+    wallet_paths = []
+
+    def _setup_wallet(uri: str):
+        keypair, wallet, wallet_path, exec_command = setup_wallet(uri)
+        wallet_paths.append(wallet_path)
+        return keypair, wallet, wallet_path, exec_command
+
+    yield _setup_wallet
+
+    # Cleanup after the test
+    for path in wallet_paths:
+        shutil.rmtree(path, ignore_errors=True)

tests/e2e_tests/conftest.py

@@ -1,10 +1,7 @@
-import logging
 import time
 
 from bittensor_cli.src.bittensor.balances import Balance
 
-from tests.e2e_tests.utils import setup_wallet
-
 """
 Verify commands:
 
@@ -18,7 +15,7 @@
 """
 
 
-def test_root_commands(local_chain):
+def test_root_commands(local_chain, wallet_setup):
     """
     Test the root commands and inspects their output
 
@@ -33,16 +30,16 @@ def test_root_commands(local_chain):
     Raises:
         AssertionError: If any of the checks or verifications fail
     """
-    logging.info("Testing Root commands 🧪")
+    print("Testing Root commands 🧪")
 
     wallet_path_alice = "//Alice"
     wallet_path_bob = "//Bob"
 
     # Create wallet for Alice
-    keypair_alice, wallet_alice, wallet_path_alice, exec_command_alice = setup_wallet(
+    keypair_alice, wallet_alice, wallet_path_alice, exec_command_alice = wallet_setup(
         wallet_path_alice
     )
-    keypair_bob, wallet_bob, wallet_path_bob, exec_command_bob = setup_wallet(
+    keypair_bob, wallet_bob, wallet_path_bob, exec_command_bob = wallet_setup(
         wallet_path_bob
     )
 
@@ -80,16 +77,16 @@ def test_root_commands(local_chain):
 
     # Capture root information and assert correct values
     # First two rows are labels, entries start from the third row
-    bob_root_info = check_root_list.stdout.splitlines()[2].split()
+    bob_root_info = check_root_list.stdout.splitlines()[3].split()
 
     # UID: First uid is always 0
     assert bob_root_info[0] == "0"
 
     # ADDRESS: Assert correct hotkey is registered
-    assert bob_root_info[1] == wallet_bob.hotkey.ss58_address
+    assert bob_root_info[3] == wallet_bob.hotkey.ss58_address
 
     # SENATOR: Since there are senator slots empty, Bob is assigned senator status
-    assert bob_root_info[3] == "Yes"
+    assert bob_root_info[7] == "Yes"
 
     # List all root delegates in the network
     check_delegates = exec_command_alice(
@@ -105,7 +102,7 @@ def test_root_commands(local_chain):
 
     # Capture delegate information and assert correct values
     # First row are labels, entries start from the second row
-    bob_delegate_info = check_delegates.stdout.splitlines()[1].split()
+    bob_delegate_info = check_delegates.stdout.splitlines()[3].split()
 
     # INDEX: First uid is always 0
     assert bob_delegate_info[0] == "0"
@@ -166,7 +163,7 @@ def test_root_commands(local_chain):
         ],
     )
     # Capture delegate information after setting take
-    bob_delegate_info = check_delegates.stdout.splitlines()[1].split()
+    bob_delegate_info = check_delegates.stdout.splitlines()[3].split()
 
     # Take percentage: This should be 18% by default
     take_percentage = float(bob_delegate_info[7].strip("%")) / 100
@@ -210,15 +207,13 @@ def test_root_commands(local_chain):
         ],
     )
     # First row are headers, records start from second row
-    alice_delegates_info = alice_delegates.stdout.splitlines()[1].split()
+    alice_delegates_info = alice_delegates.stdout.splitlines()[4].split()
 
     # WALLET: Wallet name of Alice
     assert alice_delegates_info[0] == wallet_alice.name
 
     # SS58: address of the Bob's hotkey (Alice has staked to Bob)
-    assert wallet_bob.hotkey.ss58_address.startswith(
-        alice_delegates_info[1].replace("...", "")
-    )
+    assert wallet_bob.hotkey.ss58_address == alice_delegates_info[1]
 
     # Delegation: This should be 10 as Alice delegated 10 TAO to Bob
     delegate_stake = Balance.from_tao(float(alice_delegates_info[2].strip("τ")))
@@ -231,7 +226,7 @@ def test_root_commands(local_chain):
     # Total delegated Tao: This is listed at the bottom of the information
     # Since Alice has only delegated to Bob, total should be 10 TAO
     total_delegated_tao = Balance.from_tao(
-        float(alice_delegates.stdout.splitlines()[3].split()[3].strip("τ"))
+        float(alice_delegates.stdout.splitlines()[7].split()[3].strip("τ"))
     )
     assert total_delegated_tao == Balance.from_tao(10)
 
@@ -261,3 +256,5 @@ def test_root_commands(local_chain):
         ],
     )
     assert "✅ Finalized" in undelegate_alice.stdout
+    
+    print("✅ Passed Root commands")

tests/e2e_tests/test_root.py

@@ -1,9 +1,7 @@
 import re
-import logging
 import time
 
 from bittensor_cli.src.bittensor.balances import Balance
-from tests.e2e_tests.utils import setup_wallet
 
 """
 Verify commands:
@@ -18,7 +16,7 @@
 """
 
 
-def test_staking(local_chain):
+def test_staking(local_chain, wallet_setup):
     """
     Test staking & sudo commands and inspect their output
 
@@ -33,12 +31,12 @@ def test_staking(local_chain):
     Raises:
         AssertionError: If any of the checks or verifications fail
     """
-    logging.info("Testing staking and sudo commands🧪")
+    print("Testing staking and sudo commands🧪")
     netuid = 1
     wallet_path_alice = "//Alice"
 
     # Create wallet for Alice
-    keypair_alice, wallet_alice, wallet_path_alice, exec_command_alice = setup_wallet(
+    keypair_alice, wallet_alice, wallet_path_alice, exec_command_alice = wallet_setup(
         wallet_path_alice
     )
 
@@ -123,7 +121,7 @@ def test_staking(local_chain):
     cleaned_stake = [
         re.sub(r"\s+", " ", line) for line in show_stake.stdout.splitlines()
     ]
-    stake_added = cleaned_stake[3].split()[4].strip("τ")
+    stake_added = cleaned_stake[4].split()[4].strip("τ")
     assert Balance.from_tao(100) == Balance.from_tao(float(stake_added))
 
     # TODO: Ask nucleus the rate limit and wait epoch
@@ -169,7 +167,7 @@ def test_staking(local_chain):
 
     # Parse all hyperparameters and single out max_burn in TAO
     all_hyperparams = hyperparams.stdout.splitlines()
-    max_burn_tao = all_hyperparams[18].split()[2]
+    max_burn_tao = all_hyperparams[23].split()[2]
 
     # Assert max_burn is 100 TAO from default
     assert Balance.from_tao(float(max_burn_tao.strip("τ"))) == Balance.from_tao(100)
@@ -218,9 +216,10 @@ def test_staking(local_chain):
 
     # Parse updated hyperparameters
     all_updated_hyperparams = updated_hyperparams.stdout.splitlines()
-    updated_max_burn_tao = all_updated_hyperparams[18].split()[2]
+    updated_max_burn_tao = all_updated_hyperparams[23].split()[2]
 
     # Assert max_burn is now 10 TAO
     assert Balance.from_tao(float(updated_max_burn_tao.strip("τ"))) == Balance.from_tao(
         10
     )
+    print("✅ Passed staking and sudo commands")