Merge pull request #1200 from opentensor/fix/use-rem-root-alpha

use rem root alpha

Author: sam0x17

pallets/subtensor/src/coinbase/run_coinbase.rs

@@ -464,13 +464,13 @@ impl<T: Config> Pallet<T> {
                 root_alpha_divs
                     .entry(hotkey_j.clone())
                     .and_modify(|e| {
-                        *e = e.saturating_add(root_alpha_divs_j.saturating_to_num::<u64>())
+                        *e = e.saturating_add(rem_root_alpha_divs_j.saturating_to_num::<u64>())
                     })
-                    .or_insert(root_alpha_divs_j.saturating_to_num::<u64>());
+                    .or_insert(rem_root_alpha_divs_j.saturating_to_num::<u64>());
                 log::debug!(
                     "Stored root alpha dividends for hotkey {:?}: {:?}",
                     hotkey_j,
-                    root_alpha_divs_j.saturating_to_num::<u64>()
+                    rem_root_alpha_divs_j.saturating_to_num::<u64>()
                 );
 
                 // 2.5.2 --- Store the alpha dividends

pallets/subtensor/src/tests/coinbase.rs

@@ -39,7 +39,7 @@ fn test_dynamic_function_various_values() {
                     assert!(alpha_in_emission <= alpha_emission, "alpha_in_emission is greater than alpha_emission");
                     assert!(alpha_out_emission <= 2 * alpha_emission, "alpha_out_emission is greater than 2 * alpha_emission");
                     assert!((alpha_in_emission + alpha_out_emission) <= 2 * alpha_emission, "Sum of alpha_in_emission and alpha_out_emission is less than or equal to. 2 * alpha_emission");
-                    close( alpha_in_emission + alpha_out_emission, 2 * alpha_emission, 10 );
+                    close( alpha_in_emission + alpha_out_emission, alpha_in_emission + alpha_emission, 10 );
                     if alpha_in_emission > 0 || tao_in_emission > 0 {
                         assert!((tao_in_emission as f64 / alpha_in_emission as f64 - price).abs() < 1e-1, "Ratio of tao_in_emission to alpha_in_emission is not equal to price");
                     }
@@ -70,7 +70,7 @@ fn test_dynamic_function_price_equal_emission() {
         let expected_alpha_in: u64 =
             (alpha_block_emission * tao_subnet_emission) / tao_block_emission;
         close(alpha_in, expected_alpha_in, 10);
-        close(alpha_out, 2 * alpha_block_emission - expected_alpha_in, 10);
+        close(alpha_out, alpha_block_emission, 10);
     });
 }