Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Thread.setDaemon Deprecation Warning #130

Closed
mmb-davidsmith opened this issue Aug 11, 2023 · 1 comment · Fixed by #131
Closed

Thread.setDaemon Deprecation Warning #130

mmb-davidsmith opened this issue Aug 11, 2023 · 1 comment · Fixed by #131

Comments

@mmb-davidsmith
Copy link
Contributor

The line
https://github.com/openthread/pyspinel/blob/925075841b1258d2dfc0f6ca92cb8cdd46721f3b/spinel/codec.py#L607C1-L608C1

generates a warning when executing on python 3.10 or greater. Instead the property daemon should be set to true. Looking at https://github.com/python/cpython/blame/3.11/Lib/threading.py it seems like the property has existed for about 15 years so it's probably fine to just switch without trying to do a try/catch block.

@mmb-davidsmith
Copy link
Contributor Author

@jwhui / @abtink - Are there any tests that I should run before I PR this? I've got main...mmb-davidsmith:pyspinel:setDaemon_deprecation ready to go once I figure out what testing you would like.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant