Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equal should not check attestations #11

Open
LeoComandini opened this issue May 28, 2018 · 1 comment
Open

Equal should not check attestations #11

LeoComandini opened this issue May 28, 2018 · 1 comment

Comments

@LeoComandini
Copy link

To be consistent with python-opentimestamps, when checking if two timestamps are equal, attestations should not be checked.
@petertodd
Copy link
Member

petertodd commented May 29, 2018 via email

@LeoComandini LeoComandini mentioned this issue May 30, 2018
Merged
petertodd added a commit to opentimestamps/python-opentimestamps that referenced this issue May 31, 2018
@petertodd
Merge #34: fix timestamp equality
673e308 
c40fb06 add test for timestamp equality (LeoComandini)
970699d in timestamp equality, also attestation equality must be checked (LeoComandini)

Pull request description:

  As pointed out in opentimestamps/java-opentimestamps#11, `Timestamp` equality must check that attestations are equal.

Tree-SHA512: 218eb93aec59bb299a3a456897175e57fda9d9862267bceb3f747b8c1608be111a330f1fa36405a8aa71c5f5fc4b779e2c35e21a0ae4db0c263eb468b0355bd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petertodd @LeoComandini