Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stamp method - number of calendars (-m) parameter behavior does not reflect according another opentimestamps client libraries #20

Open
yurikilian opened this issue Sep 14, 2018 · 2 comments

Comments

@yurikilian
Copy link

yurikilian commented Sep 14, 2018

for (count=0; count < capacity && count < m; count++) {

Considering the python and javascript client libraries, when the number of the calendars (-m) parameter is used and one calendar isn't available the client should send the stamp to another calendars and not stop at first one (e.g. using -m 1).

What behavior should be elected?

Thank you

@yurikilian
Copy link
Author

Currently the client stops stamp when the count is equal m and if the calendar off another public calendar aren't used.

@RCasatta
Copy link
Member

The python impl should be considered the reference one

Considering the python and javascript client libraries, when the number of the calendars (-m) parameter is used and one calendar isn't available the client should send the stamp to another calendars and not stop at first one (e.g. using -m 1).

The client shouldn't stop at the first error for sure, at a first glance the code you are linking doesn't stop at first error, or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants