Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpReverse allows the creation of cycles in a timestmap graph #5

Open
petertodd opened this issue Sep 5, 2016 · 2 comments
Open

OpReverse allows the creation of cycles in a timestmap graph #5

petertodd opened this issue Sep 5, 2016 · 2 comments

Comments

@petertodd
Copy link
Member

Suppose we create a timestamp on 'abcd' with the following operations:

OpReverse -> 'dcba' -> OpReverse -> 'abcd'

...and we're back where we started.

Now granted, this will work just fine in the opentimestamps client, just it's an unexpected property that adds complexity in some cases. For instance, the current calendar implementation in the opentimestamps server would probably fail if you ever added a timestamp containing two reverses in a row to it.

Thoughts? Might be enough to just put a warning on it and provide mechanisms to prevent OpReverse being used in places where it can cause issues, like the server.

CC: @RCasatta

@RCasatta
Copy link
Member

RCasatta commented Sep 5, 2016

Okay, if OpReverse add complexity it's better to remove it completely in the new version.
I'll point old version timestamp file to the previous implementation

@petertodd
Copy link
Member Author

I marked it as pending depreciation so any user of it will be adequately warned: ff2ab8a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants