Skip to content

Commit

Permalink
Remove max bytes validation (hashicorp#8642) (hashicorp#15504)
Browse files Browse the repository at this point in the history
* Remove validation on max_bytes

* Test max_bytes less than 1000

* Revert max_bytes to valid value

Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored and roaks3 committed Aug 15, 2023
1 parent 7b67277 commit e32dfc5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .changelog/8642.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none

```
6 changes: 2 additions & 4 deletions google/services/pubsub/resource_pubsub_subscription.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
"time"

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"

"github.com/hashicorp/terraform-provider-google/google/tpgresource"
transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
Expand Down Expand Up @@ -173,9 +172,8 @@ If all three are empty, then the subscriber will pull and ack messages using API
Description: `User-provided suffix for Cloud Storage filename. Must not end in "/".`,
},
"max_bytes": {
Type: schema.TypeInt,
Optional: true,
ValidateFunc: validation.IntBetween(1000, 10737418240),
Type: schema.TypeInt,
Optional: true,
Description: `The maximum bytes that can be written to a Cloud Storage file before a new file is created. Min 1 KB, max 10 GiB.
The maxBytes limit may be exceeded in cases where messages are larger than the limit.`,
},
Expand Down

0 comments on commit e32dfc5

Please sign in to comment.