From 83092c856b805d3040017d102db2e51dc564ddbe Mon Sep 17 00:00:00 2001 From: Aleksandr Rybolovlev Date: Fri, 1 Sep 2023 10:16:48 +0200 Subject: [PATCH] Remove TF_ACC_TERRAFORM_VERSION from the GHA (#2256) --- .github/workflows/acceptance_tests_kind.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/acceptance_tests_kind.yaml b/.github/workflows/acceptance_tests_kind.yaml index 618c2a8fc8..540c471716 100644 --- a/.github/workflows/acceptance_tests_kind.yaml +++ b/.github/workflows/acceptance_tests_kind.yaml @@ -21,8 +21,8 @@ on: env: KUBECONFIG: ${{ github.workspace }}/.kube/config KIND_VERSION: ${{ github.event.inputs.kind_version || vars.KIND_VERSION }} - TERRAFORM_VERSION: ${{ github.event.inputs.terraformVersion || vars.TERRAFORM_VERSION }} PARALLEL_RUNS: ${{ github.event.inputs.parallelRuns || vars.PARALLEL_RUNS }} + TERRAFORM_VERSION: ${{ github.event.inputs.terraformVersion || vars.TERRAFORM_VERSION }} jobs: acceptance_tests: @@ -38,6 +38,7 @@ jobs: uses: hashicorp/setup-terraform@633666f66e0061ca3b725c73b2ec20cd13a8fdd1 # v2.0.3 with: terraform_version: ${{ env.TERRAFORM_VERSION }} + terraform_wrapper: false - name: Setup kind uses: helm/kind-action@fa81e57adff234b2908110485695db0f181f3c67 # v1.7.0 with: @@ -47,7 +48,10 @@ jobs: - name: Run Acceptance Test Suite env: KUBE_CONFIG_PATH: ${{ env.KUBECONFIG }} - TF_ACC_TERRAFORM_VERSION: ${{ env.TERRAFORM_VERSION }} TESTARGS: -run '${{ github.event.inputs.runTests }}' + # Do not set TF_ACC_TERRAFORM_PATH or TF_ACC_TERRAFORM_VERSION. + # In this case, the framework will search for the Terraform CLI binary based on the operating system PATH. + # Eventually, it will use the one we set up. + # More information: https://developer.hashicorp.com/terraform/plugin/sdkv2/testing/acceptance-tests#terraform-cli-installation-behaviors run: | make testacc