Fix timetable generation for StopTimeUpdate containing only arrival or departure #6392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miklcct
force-pushed
the
arrival-only-tripupdate
branch
from
0541650 to
7a96e1a
Compare
miklcct
changed the title
miklcct
force-pushed
the
arrival-only-tripupdate
branch
from
7a96e1a to
f60c1db
Compare
miklcct
force-pushed
the
arrival-only-tripupdate
branch
from
f60c1db to
863c0cd
Compare
miklcct
changed the title
|
I need discussion of the behavior in filling the missing times. |
t2gran
reviewed
Jan 22, 2025
| .addStop(STOP_B1, "0:01:10", "0:01:11") | ||
| .addStop(STOP_C1, "0:01:20", "0:01:21") | ||
| .addStop(STOP_A1, "0:00:00", "0:00:00") | ||
| .addStop(STOP_B1, "0:05:00", "0:10:00") // 5-minute dwell |
There was a problem hiding this comment.
Suggested change
| .addStop(STOP_B1, "0:05:00", "0:10:00") // 5-minute dwell | |
| // 5-minute dwell | |
| .addStop(STOP_B1, "0:05:00", "0:10:00") |
Trailing comments are noe allowed according to over coding guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The GTFS-RT specification does not require both arrival and departure to be provided for a TripUpdate, only either of them is enough. This fixes NEGATIVE_DWELL_TIME or NEGATIVE_HOP_TIME resulting from these updates as they were not processed correctly.
Issue
Closes #6391
Unit tests
Added
Documentation
None needed
Changelog
Bumping the serialization version id
None needed