Improve/small fixes to new Debug UI

[t2gran]

This issue contains a list of small issues with the new Debug UI.

• Change name of dynamic input from "Filters" to "Request Parameters" or just "Request"
• The input request tree is collapsed when switching the view tab from input request parameters to itineraries and back. There are to good ways to fix this:
  - Remember the state, and expand the same tree.
  - Keep set field expanded end empty fields closed.
• There is no feedback on error. OTP uses the standard error message format in GraphQL an any call may return an error. Th json must be inspected, the HTTP Status may be be 200, 4xx or 5xx. To get some kind of feedback would be nice. A very good solution would be to list the error JSON as is, not trying to parse it. A minimum solution is to just show the error message.

{ "errors": [  {
   "message": "Variable 'itineraryFilters' has an invalid value: Invalid input for enum 'ItineraryFilterDebugProfile'. No value found for name 'not_selected'",
   "locations": [  {  "line": 1, "column": 510 }  ],
   "extensions": {  "classification": "ValidationError" }
}  ]  }

• When an input field is cleared, an empty string or not_selected is passed into OTP. The desired behaviour would be to remove the argument from the request again. Testing invalid input is out of scope for the Debug UI.
• When opening the OTP GraphQL Explorer all trip arguments are listed in the query. The argument list is pruned and only set fields are listed. It would be nice if we could do the same with the query. The query is often inspected manually and all the empty fields make it harder to read. We also use it when reporting bugs - and a minimum query should be used.

Styling

• The indentation can be shrinked in the request input tree.

[leonardehrenfried]

We have a bunch of debug UI tickets still open:

• New OTP Debug UI #5330
• Debug client dynamic arguments #6258

I believe they can be closed. Can you confirm this and perhaps to the closing yourself?

[t2gran]

The #5330 is not complete.

[testower]

When opening the OTP GraphQL Explorer all trip arguments are listed in the query. The argument list is pruned and only set fields are listed. It would be nice if we could do the same with the query. The query is often inspected manually and all the empty fields make it harder to read. We also use it when reporting bugs - and a minimum query should be used.

This is confusing. What does it mean for selection fields to be "set". Does it mean non-null in the response? How can we know this up-front?

[t2gran]

This is confusing. What does it mean for selection fields to be "set". Does it mean non-null in the response? How can we know this up-front?

The variables list is the answer, it only have fields set from the UI. Her is an example:

The accessEgressPenalty: $accessEgressPenalty, alightSlackDefault: $alightSlackDefault ... is not in the list of variables.

Another problem with this is that if the API changes, then the query will not work until it is manually updated - even if the change has nothing to do with the problem reported.