-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AnomalyModule
to AnomalibModule
#2423
Rename AnomalyModule
to AnomalibModule
#2423
Conversation
Signed-off-by: Samet Akcay <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Samet Akcay <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #2423 +/- ##
=============================================
Coverage ? 78.00%
=============================================
Files ? 307
Lines ? 13153
Branches ? 0
=============================================
Hits ? 10260
Misses ? 2893
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
raise ValueError(msg) | ||
|
||
|
||
class AnomalyModule(AnomalibModule): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? Since v2 is a breaking change, maybe we can rename already
Signed-off-by: Samet Akcay [email protected]
📝 Description
This PR renames the base
AnomalyModule
class toAnomalibModule
to better align with the library's naming conventions. The originalAnomalyModule
class is kept as a deprecated alias that inherits fromAnomalibModule
to maintain backward compatibility.🛠️ Fixes 📋 [TASK] Implement Core
v2
AnomalibModule
#2365Migration Guide
For users who are currently using
AnomalyModule
:The old
AnomalyModule
will continue to work but will raise a deprecation warning. Users are encouraged to migrate toAnomalibModule
.✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.