Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: GitHub API idiosyncrasies #616

Open
claudioandre-br opened this issue Nov 17, 2024 · 2 comments
Open

[BUG]: GitHub API idiosyncrasies #616

claudioandre-br opened this issue Nov 17, 2024 · 2 comments
Labels
bug Something isn't working Done Our work is done. Should close soon. No longer happening or existing. external issues Only an external entity can solve the problem properly

Comments

@claudioandre-br
Copy link
Member

Which version of the application are you using?

1.9J1+2404, latest bleeding

Description of the bug

The GitHub API is strange:

If you run the API within a PR review, the mergeStateStatus will not be clean (even when it is clean). E.g.:

  • Approvals: 1
  • Everything else is ok (confirmed using GitHub GUI).
mergeStateStatus: {"createdBy":[],"currentBranch":{"mergeStateStatus":"UNSTABLE"},"needsReview":[]}

I'll probably remove this validation from our scripts.

Steps To Reproduce

No response

Your execution environment

No response

@claudioandre-br claudioandre-br added bug Something isn't working external issues Only an external entity can solve the problem properly keep open Do NOT close automatically. Done Our work is done. Should close soon. No longer happening or existing. and removed keep open Do NOT close automatically. labels Nov 17, 2024
@claudioandre-br
Copy link
Member Author

GitHub's security model is a bit confusing. If I'm interacting with a PR of a fork, I have the rights that the author of the fork has. I understand the motivation, but when I'm myself?

What I see in the GUI is different from what the CLI shows me. It's hard to think clearly.

@claudioandre-br
Copy link
Member Author

See also #637 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Done Our work is done. Should close soon. No longer happening or existing. external issues Only an external entity can solve the problem properly
Projects
None yet
Development

No branches or pull requests

1 participant