Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: socketdock implementation #29

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

pallavighule
Copy link

What

  • Added socketdock transport session
  • Added connect disconnect and message routes for accepting socketdock requests

pallavighule and others added 20 commits November 25, 2024 12:52
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: Rinkal Bhojani <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
Signed-off-by: pallavicoder <[email protected]>
@TimoGlastra
Copy link
Contributor

@pallavighule would it be possible to add an example setup with socketdock? Can also be added in another PR, but to make it easy to get started with SocketDock (e.g. docker-compose setup)

@pallavighule
Copy link
Author

pallavighule commented Jan 17, 2025

@pallavighule would it be possible to add an example setup with socketdock? Can also be added in another PR, but to make it easy to get started with SocketDock (e.g. docker-compose setup)

@TimoGlastra For the SocketDock setup, I referred to the repository openwallet-foundation/didcomm-mediator-socketdock, where the complete setup is already provided. If needed, I can create a separate setup document and include it in a new PR. Please let me know your thoughts!

@jleach
Copy link
Contributor

jleach commented Feb 11, 2025

@TimoGlastra @pallavighule This one stalled? Wondering what we need to do to nudge it forward?

@genaris
Copy link

genaris commented Feb 11, 2025

@TimoGlastra @pallavighule This one stalled? Wondering what we need to do to nudge it forward?

There are needed changes in Credo core to make this actually work in multi-instance environments. We started discussing about this in last Credo Contributors meeting. Surely we'll follow this up next Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants