Fix incorrect logic for determining when an uploaded file can be over…

…written.
openwebwork · Jul 30, 2024 · 25c9129 · 25c9129
1 parent 165fa8e
commit 25c9129
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/WeBWorK/ContentGenerator/Instructor/FileManager.pm b/lib/WeBWorK/ContentGenerator/Instructor/FileManager.pm
@@ -754,10 +754,12 @@ sub Upload ($c) {
 			&& grep { Mojo::File->new("$dir/$name")->realpath eq Mojo::File->new("$c->{courseRoot}/$_")->realpath }
 			@{ $c->ce->{uneditableCourseFiles} };
 
-		if (($invalidUploadFilenameMsg || $isProtected)
-			|| !$c->param('overwrite')
-			|| $action ne 'Overwrite'
-			|| $action ne $c->maketext('Overwrite'))
+		if (
+			($invalidUploadFilenameMsg || $isProtected)
+			|| (!$c->param('overwrite')
+				&& $action ne 'Overwrite'
+				&& $action ne $c->maketext('Overwrite'))
+			)
 		{
 			return $c->c(
 				$c->Confirm(