Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of Hmwk Sets Editor and possibly Classlist Editor #1992

Closed
dlglin opened this issue May 18, 2023 · 17 comments
Closed

Change name of Hmwk Sets Editor and possibly Classlist Editor #1992

dlglin opened this issue May 18, 2023 · 17 comments

Comments

@dlglin
Copy link
Member

dlglin commented May 18, 2023

"Hmwk" needs to be replaced with a full word. There was discussion about the fact that not all sets are homework, so we should find a different name. Suggestions include "Assignments" or just "Sets".

Also consensus seemed to be that this should be changed from "Editor" to "Manage".

How about:

  • "Classlist Editor" -> "Manage Users"
  • "Hmwk Sets Editor" -> "Manage Assignments"

The biggest implication of this would be to existing documentation. Both internal documentation and custom site-specific documentation refer to the old names, which may make people confused and/or unhappy.

@pstaabp
Copy link
Member

pstaabp commented May 23, 2023

I would argue to make the new name nouns to roughly fit it with the rest of the name of the tools. Perhaps:

  • "Classlist Editor" -> User Manager
  • "Hmwk Sets Editor " Assignment Manager

@drgrice1
Copy link
Member

drgrice1 commented Nov 4, 2023

It seems that the Achievement Editor should also be renamed. Perhaps to Achievement Manager. The name Achievement Editor is confusing when there is also an page that is for editing achievement evaluators that seems more like an Achievement Editor than this page.

@Alex-Jordan
Copy link
Contributor

For a little while now in develop, in the TOC we've had:

User Manager
Set Assigner
Set Manager
Screenshot 2023-11-24 at 11 42 49 PM

Each time I go into a course on develop (to test or develop something) I see these and I'm not liking them. At first I thought it was just reflex because they are new and different. But now I'm starting to feel that I dislike these for more than just the bias of familiarity. Does anyone feel similarly? With the repeated use of Set and Manager, it feels cluttered. Or like it's missing a User Assigner to round it out. Set Assigner bugs me now, because you can "assign the sets to users" but you could also think of it as "assigning the users to the sets".

It's hard to think of better names. But I'm going to toss out these and see if anything sticks in the opinions of others reading this. In addition to renaming those three, I renamed Acheivement Editor as @drgrice1 suggested (except with plural). And also Homework Sets at the top of the TOC.

Screenshot 2023-11-24 at 11 48 34 PM

@somiaj
Copy link
Contributor

somiaj commented Nov 25, 2023

I to have had a bit of trouble navigating with the new menu, but still getting use to it. I do like the idea of replacing Set Assigner with Assigner Tool, this makes it more similar to Instructor Tools (which it is just a special case of). That might help make things look a little less similar. I don't know about your other suggestions though, I think they are less descriptive. I think User Manager is a better description than Course Roster, also I like the repeated use of Manager to help distinguish what the page is.

@Alex-Jordan
Copy link
Contributor

A few more alternatives I'm trying out:

Screenshot 2023-11-25 at 10 25 55 AM

This combo eliminates "User". "User" is comfortable for software designers and someone who views drug addiction as a life choice. But if I'm a typical instructor, I don't think of my students as "users".

@somiaj
Copy link
Contributor

somiaj commented Nov 25, 2023

I like your last suggestion best of them so far. I'm okay with replacing "User", it was the "Manger" part I liked over "Roster".

@drgrice1
Copy link
Member

I think your last suggestion sounds reasonable. I also don't like the "Course Roster" suggestion. That seems to specific when there are more users than just students that are managed on that page, and a roster typically refers to just students enrolled in the course.

@Alex-Jordan
Copy link
Contributor

I've lumped a lot of things here, so I should recap:

'Homework Sets' => 'Assignments',
'User Settings' => 'Account Settings',
'User Manager'  => ('Course Roster', 'Accounts Manager'),
'Set Assigner'  => 'Assigner Tool',
'Set Manager'   => 'Sets Manager',
'Achievement Editor' => ('Achievement Manager', 'Achievements Manager'),

Do all of these sound like improvements? I don't want to impose my taste; whatever subset of these (or new suggestions) people are god with, I'll open a PR. It sounds like 'User Manager' => 'Accounts Manager' and 'Set Assigner' => 'Assigner Tool', are good.

@drgrice1
Copy link
Member

I think

'Homework Sets' => 'Assignments',
'User Settings' => 'Account Settings',
'User Manager'  => 'Accounts Manager',
'Set Assigner'  => 'Assigner Tool',
'Set Manager'   => 'Sets Manager',
'Achievement Editor' => 'Achievements Manager'

sounds good to me. I think going with consistent plurals is a good idea.

@somiaj
Copy link
Contributor

somiaj commented Nov 27, 2023

I would be okay with:

'Homework Sets'      => 'Assignments',
'User Settings'      => 'Account Settings',
'User Manager'       => 'Accounts Manager'
'Set Assigner'       => 'Assigner Tool',
'Set Manager'        => 'Sets Manager',
'Achievement Editor' => 'Achievements Manager'

@somiaj
Copy link
Contributor

somiaj commented Nov 27, 2023

Any thoughts on switching the order of Assigner Tool and Accounts Manager (so Assigner Tool is right below Instructor Tools)? Just a side thought, I do think these will help with some of the minor issues I have had getting use to the new menu, but won't really know until I use it for a while.

@Alex-Jordan
Copy link
Contributor

Consistent plurals...except not with "File Manager"? I can't bring myself to like "Files Manager". But I'll do it if we like the consistency.

@drgrice1
Copy link
Member

Yeah, I don't like Files Manager either. I didn't think of that one in this.

@Alex-Jordan
Copy link
Contributor

Alex-Jordan commented Nov 27, 2023 via email

@dlglin
Copy link
Member Author

dlglin commented Nov 27, 2023

I'll throw in another suggestion for discussion: would it be clearer to make the names into actions? e.g. "Manage Users", "Manage Sets", "Assign Sets", "Manage Course Files", etc?

@Alex-Jordan
Copy link
Contributor

I like verbs for buttons (basically stay on the same page but change something about the page or submit a form), but nouns for links (go to a new page).

@pstaabp
Copy link
Member

pstaabp commented Feb 21, 2024

Changed in #2265

@pstaabp pstaabp closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants