-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openwrt] Allow configure DNS resolvers without the need of defining interfaces #117
Comments
I have gone through the codebase and found out that the dns converters are defined within the interface converters. so if there is no interface in the |
interfaces openwisp#117 Fixed the issue by defining two additional classes (DnsServer and DnsSearch) in the interfaces converter. These additional classes are to convert the dns configs when an interface is not provided in the netjson. when an interface is provided, the default converters in the Interface class is used to convert the dns to native config. this was left so because when an interface is defined, other options like DHCP servers might be available and the Interface class handles that very well. Test cases were added to test for these features and also to increase the coverage. Fixes openwisp#117
…openwisp#117 Fixed the issue by defining two additional classes (DnsServer and DnsSearch) in the interfaces converter. These additional classes are to convert the dns configs when an interface is not provided in the netjson. when an interface is provided, the default converters in the Interface class is used to convert the dns to native config. this was left so because when an interface is defined, other options like DHCP servers might be available and the Interface class handles that very well. Test cases were added to test for these features and also to increase the coverage. Fixes openwisp#117
I went through the openwrt documentation and it seems that dns configuration on openwrt can be done only in two places , i.e under the |
As far as I understand, the option to use the Setting it in Another option is to directly manipulate the |
In OpenWRT, dns settings are configured at interface level, you need to define some interfaces to make this config effective on OpenWRT.
Eg:
But this is not very good. There should be a way to make the DNS configuration work also when
interfaces
are not defined.The text was updated successfully, but these errors were encountered: