Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] Update to latest echarts version #305

Open
nemesifier opened this issue Nov 29, 2024 · 3 comments · May be fixed by #334
Open

[deps] Update to latest echarts version #305

nemesifier opened this issue Nov 29, 2024 · 3 comments · May be fixed by #334
Labels
enhancement

Comments

@nemesifier
Copy link
Member

Updating echarts to the latest version requires some adjustments due to some examples which aren't working.

Another issue is that the tests aren't failing, we need a few tests which can replicate the same bug shown in the examples, so that in the future we'll be able to upgrade more smoothly.
@nemesifier nemesifier changed the title [deps] Update code to acommodate latest echarts version [deps] Update to latest echarts version Nov 29, 2024
@nemesifier nemesifier moved this from Backlog to To do in OpenWISP Priorities for next releases Nov 29, 2024
@Unnati-Gupta24
Copy link
Contributor

Hello @nemesifier.
I hope this message finds you well. My name is Unnati, and I am currently pursuing my Bachelor's degree in Computer Science. I would like to express my interest in updating the ECharts version to 5.5.1, which is the latest release. Additionally, I would appreciate your guidance on the bugs identified in the test, as I am eager to work on this issue. If possible, I kindly request that you assign it to me. Thank you for considering my request, and I look forward to your response.

@nemesifier
Copy link
Member Author

@Unnati-Gupta24 you can proceed! Come to the OpenWISP dev chat to coordinate.

@nemesifier nemesifier mentioned this issue Dec 4, 2024
Merged
4 tasks
dee077 added a commit to dee077/netjsongraph.js that referenced this issue Feb 18, 2025
@dee077
[deps] Update ECharts to version 5.6.0 openwisp#305
47e49c4 
Modify import statements according to the updated ECharts module structure.

Fixes openwisp#305, openwisp#244
@dee077 dee077 linked a pull request Feb 18, 2025 that will close this issue
Open
3 tasks
@KumarADITHYA123
Copy link

"Hi! my name is kumar I'd like to work on this issue. Could you please assign it to me?"

@KumarADITHYA123 KumarADITHYA123 mentioned this issue Feb 19, 2025
Closed
dee077 added a commit to dee077/netjsongraph.js that referenced this issue Feb 22, 2025
@dee077
[deps] Update ECharts to version 5.6.0 openwisp#305
6a143cd 
Modify import statements according to the updated ECharts module structure. Increased line height to ensure the tooltip elements does not overlap

Fixes openwisp#305, openwisp#224
dee077 added a commit to dee077/netjsongraph.js that referenced this issue Feb 22, 2025
@dee077
[tests] Added Selenium test for Geographic map render
960ed5a 
Setup Selenium Chrome WebDriver to test that the Geographic map renders correctly, checks for console errors, and verifies nodes and links count.

Fixes openwisp#305, openwisp#269
dee077 added a commit to dee077/netjsongraph.js that referenced this issue Feb 24, 2025
@dee077
[tests] Fixes build checks failure openwisp#305
86b0799 
Added a test for the basic usage example. Fixed issues arised when writing multiple tests. Added yarn start and support for chromedriver in github actions. Resolved some naming inconsistencies.

Fixes openwisp#305, openwisp#269
dee077 added a commit to dee077/netjsongraph.js that referenced this issue Feb 25, 2025
@dee077
[tests] Completed function for getting nodes and links count for all …
79dc5ae 
…examples openwisp#305

Covered all the examples to get nodes and links and count. switched from if-else to object mapping for a cleaner structure.

Fixes openwisp#305
dee077 added a commit to dee077/netjsongraph.js that referenced this issue Feb 26, 2025
@dee077
[tests] Optimize test execution time and update README openwisp#305
70b9242 
Reduced per-test timeout to the default 5s and lowered element render wait time to 2s to minimize delays. Also updated documentation to include test execution guidelines.\
-m Fixes
dee077 added a commit to dee077/netjsongraph.js that referenced this issue Feb 26, 2025
@dee077
[tests] Optimize test execution time and update README openwisp#305
5aa2c04 
Reduced per-test timeout to the default 5s and lowered element render wait time to 2s to minimize delays. Updated documentation to include test execution guidelines.

Fixes openwisp#305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
OpenWISP Contributor's Board
Status: To do (general)
OpenWISP Priorities for next releases
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[deps] Update ECharts to version 5.6.0 #305 dee077/netjsongraph.js
3 participants
@nemesifier @KumarADITHYA123 @Unnati-Gupta24