Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Execute tests even if QA checks fail, build anyway #136

Merged
merged 1 commit into from
Jul 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
name: OpenWRT OPENWISP MONITORING CI Build
---

name: OpenWRT OpenWISP Monitoring CI Build

on:
push:
Expand All @@ -22,11 +24,11 @@ jobs:
with:
python-version: "3.8"

- name: Install Python dependencies
run: pip install openwisp-utils[qa]

- name: Install Development dependencies
run: sudo ./install-dev.sh
- name: Install dependencies
id: deps
run: |
pip install openwisp-utils[qa]
sudo ./install-dev.sh

- name: QA-Checks
run: ./run-qa-checks
Expand All @@ -41,9 +43,11 @@ jobs:
sh_checker_comment: true

- name: Tests
if: ${{ !cancelled() && steps.deps.conclusion == 'success' }}
run: ./runtests

- name: Upload Coverage
if: ${{ success() }}
run: |
cd openwisp-monitoring/tests
luacov-coveralls -v
Expand All @@ -52,7 +56,6 @@ jobs:

build:
name: Build and upload package as artifacts
needs: tests
runs-on: ubuntu-20.04
env:
BUILD_DIR: '/home/runner/work/build'
Expand Down Expand Up @@ -87,6 +90,7 @@ jobs:
CI_CACHE: ${{ steps.cache.outputs.cache-hit }}

- name: Upload packages as artifacts
if: ${{ github.event_name=='push' }}
uses: actions/upload-artifact@v2
with:
name: Packages
Expand Down
Loading