Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Simplified compiling package without iwinfo #144

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Nov 6, 2024

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Description of Changes

Copy iwinfo.lua only when CONFIG_NETJSON_MONITORING_IWINFO is set to true.

@coveralls
Copy link

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 11725414195

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 99.597%

Files with Coverage Reduction New Missed Lines %
../files/lib/openwisp-monitoring/monitoring.lua 2 85.71%
Totals Coverage Status
Change from base Build 11042830109: -0.06%
Covered Lines: 3216
Relevant Lines: 3229

💛 - Coveralls

@pandafy pandafy force-pushed the iwinfo-optional branch 5 times, most recently from 44ae3e5 to 50913b2 Compare November 7, 2024 14:07
Copy iwinfo.lua only when CONFIG_NETJSON_MONITORING_IWINFO is set
to true.
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@nemesifier nemesifier merged commit 6282262 into master Nov 7, 2024
2 checks passed
@nemesifier nemesifier deleted the iwinfo-optional branch November 7, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants