Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results contains no extract #95

Open
benoit74 opened this issue Nov 25, 2024 · 3 comments
Open

Search results contains no extract #95

benoit74 opened this issue Nov 25, 2024 · 3 comments
Assignees
Labels
bug Something isn't working question Further information is requested
Milestone

Comments

@benoit74
Copy link
Contributor

benoit74 commented Nov 25, 2024

Search result do not contain any text extract, only the title. Why?

Image

@benoit74 benoit74 added bug Something isn't working question Further information is requested labels Nov 25, 2024
@benoit74 benoit74 added this to the 0.1 milestone Nov 25, 2024
@benoit74 benoit74 self-assigned this Nov 25, 2024
@benoit74
Copy link
Contributor Author

Guess: I'm pretty sure this is because we have no real HTML content on these pages, we just pass the indexing content to the libzim, but the real page has no content.

Not sure we can do anything for this, since there is no real content to preview

@kelson42
Copy link

@benoit74 You are probably right, but I don't really see why it should not be fixable (maybe by extending scraperlib/pylibzim API).

@benoit74
Copy link
Contributor Author

We should probably discuss this live, because I don't see which libzim API could be used to fix this.

Currently what we have for each page the user "see" is:

  • 1 real "textual" content stored in a JSON file, used by the Vue.JS application
  • 1 "fake" redirect-only HTML entry, for which we pass the "textual" content to the libzim so that both search index are properly populated ; this entry has no text inside its HTML since it is not supposed to be displayed, only to redirect to proper URL inside the Vue.JS application

And if I'm not mistaken, what has been discussed is that we should find a solution in libzim / ZIM format to not even need this "fake" redirect-only HTML entry, just store an entry without any content but a proper redirect URL (btw, I consider it could even be wiser to attach this directly to the JSON file, but to be discussed). But this is a different topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants