ZIM filename does not match requirements

[benoit74]

When creating a schedule, the provided filename does not match our convention and is refused by the Zimfarm since openzim/zimfarm#865 has been merged.

[benoit74]

I see two paths forward on this issue:

1. we modify the check for zim filename validity on farm.youzim.it
   1. either we allow to pass a custom regex for this instance via an optional environment variable
   2. or we completely disable the ZIM filename check via an optional environment variable
2. we modify zimit to also support the {lang} placeholder in ZIM filename + zimfarm to allow this as a valid filename
   1. youzim.it ZIM filename would become {url_hostname}_{lang}_{unique_id_6_chars}_{period}.zim instead of {url_hostname}_{unique_id_8_chars}.zim
   2. {unique_id_8_chars} is not really a selection ...
   3. maybe {url_hostname}_{lang}_all_{unique_id_6_chars}_{period}.zim would make more sense

I prefer option 2 since:

• it would allow to produce filenames almost matching our own convention which is probably not a bad thing
• adding support for {lang} placeholder in zimfarm is a most probably a useful feature in other situations (scrapers producing multiple languages at once would benefit from this as well)

[rgaudin]

youzim.it filenames have already been debated a lot. @Popolechien have been very insistent on the filenames being user-centered given those are not in the catalog. Including the unique ID (so we can safely store them in a flat folder) required some convincing.

Additionally, the period makes zero sense in the context of youzim.it: it's creation is manual and not periodic and this month-period would only bring confusion.

I thus think option 1 is more practical. I don't recall how wp1 filenames are constructed. They might not fit the pattern neither

[benoit74]

WP1 is not impacted from what I looked after because we validate only output, description, long description and other basic range / oneOf validations.

OK for option 1 if this is what fits you.

[rgaudin]

@Popolechien can confirm whether it still makes sense to him

[Popolechien]

yes.

[benoit74]

I've opened upstream issue since nothing has to be done in zimit-frontend in the end: openzim/zimfarm#867 (and I will work on it tomorrow)