Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing .proto for all API specs #74

Open
dio opened this issue May 10, 2019 · 1 comment
Open

Consider providing .proto for all API specs #74

dio opened this issue May 10, 2019 · 1 comment

Comments

@dio
Copy link

dio commented May 10, 2019

Currently, zipkin APIs are represented as:

  1. v1, http-json, through https://github.com/openzipkin/zipkin-api/blob/master/zipkin-api.yaml
  2. v2, http-json, through https://github.com/openzipkin/zipkin-api/blob/master/zipkin2-api.yaml and also we have http-proto with messages defined in https://github.com/openzipkin/zipkin-api/blob/master/zipkin.proto

To make it seamless and take advantage of protobuf tooling when making zipkin clients, I think it is a good idea to have .proto for all available API specs (including v1 and v2 http json). E.g. in Envoy we can purely use protobuf helps without a detour on using json lib like rapidjson.

We can consider bringing: https://github.com/nytimes/openapi2proto to generate .proto from openapi spec.

@codefromthecrypt
Copy link
Member

didn't notice this issue existed #77 partially implements it. v1 is not reverse mapped yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants