Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getFollowsControllerNamespaceChanges and withNamespacesInheritedFromController to InformerEventSourceConfiguration #2673

Open
csviri opened this issue Jan 25, 2025 · 3 comments
Open

Move getFollowsControllerNamespaceChanges and withNamespacesInheritedFromController to InformerEventSourceConfiguration #2673

csviri opened this issue Jan 25, 2025 · 3 comments
Milestone
5.1

Comments

@csviri
Copy link
Collaborator

csviri commented Jan 25, 2025

Currently are in InformerConfiguration, but logically does not belong there.
@csviri csviri added this to the 5.0 milestone Jan 25, 2025
@metacosm metacosm changed the title Move getFollowsControllerNamespaceChanges and withNamespacesInheritedFromController to InformerEvetnSourceConfiguration Move getFollowsControllerNamespaceChanges and withNamespacesInheritedFromController to InformerEventSourceConfiguration Jan 25, 2025
@metacosm
Copy link
Collaborator

This is used for getEffectiveNamespaces which is used in different spots. At this point, I'd rather leave it as-is.

@csviri
Copy link
Collaborator Author

csviri commented Jan 27, 2025

Hmm, ok let's revisit this for 5.1

@csviri csviri modified the milestones: 5.0, 5.1 Jan 27, 2025
@metacosm
Copy link
Collaborator

Should we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1
Development

No branches or pull requests
2 participants
@metacosm @csviri