Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly generate "adjective_animal_verb_adverb" #3274

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

revosw
Copy link
Contributor

@revosw revosw commented Dec 16, 2024

There was a discrepancy between randomHumanId() and humanIdHash(). humanIdHash had the correct "adjective_animal_verb_adverb" structure, but randomHumanId() had "adjective_adjective_animal_verb"

Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: 8ca1460

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samuelstroschein
Copy link
Member

Thanks for the PR!

@samuelstroschein samuelstroschein merged commit cfe3c8f into opral:main Dec 16, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants