From 3302bc733112a5a8bc94963ecff2ba403b26c33f Mon Sep 17 00:00:00 2001
From: Andrea Iob <andrea_iob@hotmail.com>
Date: Wed, 29 May 2024 20:17:44 +0200
Subject: [PATCH] discretization: avoid hiding virtual functions with other
 functions with the same name

---
 src/discretization/stencil_solver.hpp |  2 +-
 src/discretization/stencil_solver.tpp | 12 ++----------
 2 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/src/discretization/stencil_solver.hpp b/src/discretization/stencil_solver.hpp
index bd474ef925..d68d13a2f9 100644
--- a/src/discretization/stencil_solver.hpp
+++ b/src/discretization/stencil_solver.hpp
@@ -239,7 +239,7 @@ class DiscretizationStencilSolver : public solver_kernel_t {
 
     using solver_kernel_t::solver_kernel_t;
 
-    void clear(bool release = false);
+    void clear() override;
 
     template<typename stencil_container_t = std::vector<stencil_t>>
     void assembly(const stencil_container_t &stencils);
diff --git a/src/discretization/stencil_solver.tpp b/src/discretization/stencil_solver.tpp
index 9d45e33182..9f495cec15 100644
--- a/src/discretization/stencil_solver.tpp
+++ b/src/discretization/stencil_solver.tpp
@@ -1014,21 +1014,13 @@ const stencil_t & DiscretizationStencilSolverAssembler<stencil_t, solver_kernel_
 
 /*!
 * Clear the stencil solver
-*
-* \param release if it's true the memory hold by the stencil solver will be
-* released, otherwise the stencil solver will be cleared but its memory will
-* not be relased
  */
 template<typename stencil_t, typename solver_kernel_t>
-void DiscretizationStencilSolver<stencil_t, solver_kernel_t>::clear(bool release)
+void DiscretizationStencilSolver<stencil_t, solver_kernel_t>::clear()
 {
     solver_kernel_t::clear();
 
-    if (release) {
-        std::vector<double>().swap(m_constants);
-    } else {
-        m_constants.clear();
-    }
+    std::vector<double>().swap(m_constants);
 }
 
 #if BITPIT_ENABLE_MPI==1