Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of Sobol initialization is always equal or greater than sim_workers #220

Closed
delaossa opened this issue Jun 10, 2024 · 2 comments
Closed

Comments

@delaossa
Copy link
Collaborator

For all cases that I have checked (starting from scratch, resuming, adding evaluations manually, etc.), the minimum number of Sobol evaluations is always sim_workers, even if n_init < sim_workers, or if there is already evaluations added manually or from a previous run.
For these last cases, I would expect that the generation strategy changes to BO immediately.

@AngelFP
Copy link
Member

AngelFP commented Jun 11, 2024

Hi @delaossa , that's right. Thanks for spotting that. It looks like this was an issue introduced in #207, and which was also causing the tests to fail in #185. A fix is now included as part of #185.

@AngelFP AngelFP closed this as completed Jun 11, 2024
@delaossa
Copy link
Collaborator Author

Excellent! Muchas gracias, Angel! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants