Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing incident.start_time does not change first status.mtime #12

Open
optiz0r opened this issue Jun 6, 2012 · 1 comment
Open

Changing incident.start_time does not change first status.mtime #12

optiz0r opened this issue Jun 6, 2012 · 1 comment

Comments

@optiz0r
Copy link
Owner

optiz0r commented Jun 6, 2012

Changing the start_time of an incident does not update the mtime of the first incident, so the statusboard on /home/ does not show the updated times. The first status mtime should be updated to match.

A problem will occur if the time is brought forward past the creation of a status change so as to orphan a status change before the incident was even created.

@optiz0r
Copy link
Owner Author

optiz0r commented Jun 7, 2012

Commit f399406 partially fixes this issue. When the incident start_time is changed, the ctime of the initial status is also updated so as to display correctly throughout the application. Subsequent status changes are not amended.

This feature is useful in the case where planned future maintenance is rearranged, but can be misused to change past incidents as well.

Reasonable options are:

  • Accept that users shouldn't be changing the timestamp of something that's already happened and ignore the breakage. it doesn't mess up the webui, but does look odd in the status history for the incident.
  • Prevent start_time changes if that time has already elapsed
  • Force the timestamps for all subsequent status changes to be amended when changing the incident start time (additional UI required)
  • Delete all status changes with a time before the new incident start time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant