Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate allennlp and chainer integrations #51

Conversation

HideakiImamura
Copy link
Member

Motivation

The tests of allennlp and chainer integrations were deleted. This PR adds the deprecated decorator to those integrations.

Description of the changes

Deprecate allennlp and chainer integrations

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f87c5de) 2.66% compared to head (0a54ac3) 2.66%.
Report is 1 commits behind head on main.

Files Patch % Lines
optuna_integration/chainer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #51   +/-   ##
=====================================
  Coverage   2.66%   2.66%           
=====================================
  Files         12      12           
  Lines         75      75           
=====================================
  Hits           2       2           
  Misses        73      73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@contramundum53 contramundum53 self-assigned this Dec 7, 2023
@contramundum53 contramundum53 merged commit 5a91bd0 into optuna:main Dec 7, 2023
11 of 12 checks passed
@HideakiImamura HideakiImamura added this to the v3.5.0 milestone Dec 8, 2023
@nabenabe0928 nabenabe0928 added the compatibility Change that breaks compatibility. label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Change that breaks compatibility.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants