From 13e63a6977b228bbb9c053269ec1a1782a2f39b6 Mon Sep 17 00:00:00 2001 From: nabenabe0928 Date: Wed, 30 Oct 2024 06:24:18 +0100 Subject: [PATCH] Apply c-bata's comments --- .../auto_sampler/tests/test_sampler.py | 57 ------------------- 1 file changed, 57 deletions(-) diff --git a/package/samplers/auto_sampler/tests/test_sampler.py b/package/samplers/auto_sampler/tests/test_sampler.py index de9e6f46..6677d1a8 100644 --- a/package/samplers/auto_sampler/tests/test_sampler.py +++ b/package/samplers/auto_sampler/tests/test_sampler.py @@ -77,63 +77,6 @@ ) -""" -@pytest.mark.parametrize( - # TODO: 知らん - "sampler_class,expected_has_rng,expected_has_another_sampler", [(AutoSampler, ..., ...)] -) -def test_sampler_reseed_rng( - sampler_class: Callable[[], BaseSampler], - expected_has_rng: bool, - expected_has_another_sampler: bool, -) -> None: - def _extract_attr_name_from_sampler_by_cls(sampler: BaseSampler, cls: Any) -> str | None: - for name, attr in sampler.__dict__.items(): - if isinstance(attr, cls): - return name - return None - - sampler = sampler_class() - - rng_name = _extract_attr_name_from_sampler_by_cls(sampler, LazyRandomState) - has_rng = rng_name is not None - assert expected_has_rng == has_rng - if has_rng: - rng_name = str(rng_name) - original_random_state = sampler.__dict__[rng_name].rng.get_state() - sampler.reseed_rng() - random_state = sampler.__dict__[rng_name].rng.get_state() - if not isinstance(sampler, optuna.samplers.CmaEsSampler): - assert str(original_random_state) != str(random_state) - else: - # CmaEsSampler has a RandomState that is not reseed by its reseed_rng method. - assert str(original_random_state) == str(random_state) - - had_sampler_name = _extract_attr_name_from_sampler_by_cls(sampler, BaseSampler) - has_another_sampler = had_sampler_name is not None - assert expected_has_another_sampler == has_another_sampler - - if has_another_sampler: - had_sampler_name = str(had_sampler_name) - had_sampler = sampler.__dict__[had_sampler_name] - had_sampler_rng_name = _extract_attr_name_from_sampler_by_cls(had_sampler, LazyRandomState) - original_had_sampler_random_state = had_sampler.__dict__[ - had_sampler_rng_name - ].rng.get_state() - with patch.object( - had_sampler, - "reseed_rng", - wraps=had_sampler.reseed_rng, - ) as mock_object: - sampler.reseed_rng() - assert mock_object.call_count == 1 - - had_sampler = sampler.__dict__[had_sampler_name] - had_sampler_random_state = had_sampler.__dict__[had_sampler_rng_name].rng.get_state() - assert str(original_had_sampler_random_state) != str(had_sampler_random_state) -""" - - def parametrize_suggest_method(name: str) -> MarkDecorator: return pytest.mark.parametrize( f"suggest_method_{name}",