Add HEBO sampler supporting Define-by-Run manner, maximization, parallelization, and constant_liar #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabenabe0928
reviewed
Dec 4, 2024
| @@ -0,0 +1,3 @@ | |||
| optuna | |||
| optunahub | |||
| hebo@git+https://github.com/huawei-noah/[email protected]#subdirectory=HEBO | |||
There was a problem hiding this comment.
How about using hebo?
Suggested change
| hebo@git+https://github.com/huawei-noah/HEBO.git@v0.3.6#subdirectory=HEBO | |
| hebo==0.3.6 |
There was a problem hiding this comment.
This is the exact same code as the preceding HEBO package, so I would prefer to maintain it.
Comment on lines
43
to
44
| if len([t for t in trials if t.state == TrialState.COMPLETE]) < 1: | ||
| return {} |
There was a problem hiding this comment.
I think it would be better to use hebo.suggest even if we do not have completed trials, because hebo.suggest uses qmc if I remember correctly.
There was a problem hiding this comment.
This sampler does not call hebo.suggest() here because it needs to know search space by running the first trial.
(It uses BaseSampler, so search space is not given.)
I have added comment about this in the code.
nabenabe0928
reviewed
Dec 4, 2024
Co-authored-by: Shuhei Watanabe <[email protected]>
y0z
reviewed
Dec 4, 2024
Co-authored-by: Shuhei Watanabe <[email protected]>
Co-authored-by: Yoshihiko Ozaki <[email protected]>
|
I will close this PR and make new PR, which adds these functionalities to existing HEBO package. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Agreements
Please read the contributor agreements and if you agree, please click the checkbox below.
Tip
Please follow the Quick TODO list to smoothly merge your PR.
Motivation
I would like to see a HEBO implementation that can drop-in replacement of Sampler in Optuna code that is written in Define-by-Run (its search space is not conditional).
I also want it to support parallelization.
Description of the changes
Add another package of HEBO.
TODO List towards PR Merge
Please remove this section if this PR is not an addition of a new package.
Otherwise, please check the following TODO list:
./template/to create your package<COPYRIGHT HOLDER>inLICENSEof your package with your nameREADME.mdin your package__init__.pyfrom __future__ import annotationsat the head of any Python files that include typing to support older Python versionsREADME.mdREADME.md