Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built-in GridSampler #45

Merged
merged 1 commit into from
May 23, 2024
Merged

Add built-in GridSampler #45

merged 1 commit into from
May 23, 2024

Conversation

not522
Copy link
Member

@not522 not522 commented May 23, 2024

Contributor Agreements

Please read the contributor agreements and if you agree, please click the checkbox below.

  • I agree to the contributor agreements.

Motivation

This PR will make GridSampler available from OptunaHub.

Description of the changes

Add built-in GridSampler as a new package.

@not522 not522 added the new-package New packages label May 23, 2024
@not522 not522 force-pushed the grid-sampler branch 2 times, most recently from dafc317 to ea8c90a Compare May 23, 2024 05:22
@y0z y0z self-requested a review May 23, 2024 05:27
@y0z
Copy link
Member

y0z commented May 23, 2024

It seems to include an implementation of random search in addition to grid search by mistake.

  • package/samplers/random_search/LICENSE
  • package/samplers/random_search/README.md
  • package/samplers/random_search/__init__.py

@not522
Copy link
Member Author

not522 commented May 23, 2024

Thank you. I deleted files that were added unintentionally.

@not522 not522 changed the title Add built-in GridSampler Add built-in GridSampler May 23, 2024
@y0z
Copy link
Member

y0z commented May 23, 2024

LGTM

@y0z y0z merged commit 9249e1e into main May 23, 2024
4 checks passed
@y0z y0z deleted the grid-sampler branch May 23, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package New packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants