Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update createTokenAmount() and createScaledNumber() return type #175

Open
haythemsellami opened this issue Sep 14, 2020 · 1 comment
Open

Update createTokenAmount() and createScaledNumber() return type #175

haythemsellami opened this issue Sep 14, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone
v2 launch

Comments

@haythemsellami
Copy link
Member

Update the function createScaledNumber() and createTokenAmount() to return a BigNumber instead of a string, will be more scalable for different use cases.
@haythemsellami haythemsellami added the enhancement New feature or request label Sep 14, 2020
@antoncoding
Copy link
Contributor

let's wait until all the integration tests are done? otherwise will have too many conflicts in each merge

@antoncoding antoncoding added this to the v2 launch milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2 launch
Development

No branches or pull requests
2 participants
@haythemsellami @antoncoding