Skip to content

displaying directory history for Mercurial repository takes way too long #3901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vladak opened this issue Feb 16, 2022 · 2 comments
Open
Assignees
Labels

Comments

@vladak
Copy link
Member

vladak commented Feb 16, 2022

Watching the Grafana latencies dashboard for internal production instance I noticed very high (minutes) latencies for some history queries in a Mercurial repository (Solaris ON). Trying it myself I realized that this was caused by the rich options used when getting the history for directories (yes it is still using Mercurial with Python 2.7. Also, directory history is a bit difficult to cache - #1704):

  12138 /usr/bin/python2.7 /usr/bin/hg log -r reverse(0::'default') --template changeset: {rev}:{node|short}\nuser: {author}\ndate: {date|isodate}\ndescription: {desc|strip|obfuscate}\nfiles: {files}\nfile_copie...

while the history for the same repository can be retrieved from command line without any --template in bunch of seconds - still bad but not ugly. The thing is that these {files} and such are important mainly for the indexer. Thanks to this template the UI is able to display the files after clicking on the 'Show modified files' link in the 'Comments' column in the history view for each changeset however it might not be worth it. Maybe the page should be bare (w.r.t. files) and only the link should trigger the heavy lifting.

@vladak
Copy link
Member Author

vladak commented Feb 16, 2022

The handling of directory history w.r.t. files in Git should be investigated as well.

@vladak vladak changed the title displaying log of a directory in Mercurial repository takes way too long displaying directory history for Mercurial repository takes way too long Feb 16, 2022
@vladak vladak self-assigned this Feb 16, 2022
@vladak
Copy link
Member Author

vladak commented Nov 26, 2022

This is similar to #4023 but not same as it has some Mercurial specifics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant