-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Android setSmallIcon when used with an XML resource adds unneeded padding, makes notification icon look incorrect. #21
Comments
Please share the XML file that has this issue. |
The xml you have shared is for launcher icon. When a launcher icon xml is used as a notification icon, there is a padding added by the system. Firebase SDK reads the icon xml as a launcher icon, so the padding is not added by the system. Responsys SDK reads the icon xml as a notification icon, so the padding is added by the system. There are two ways to resolve this,
|
Just wanted to let you know the following does not work.
Not setting the icon in Responsys causes a blank white circle icon. Otherwise we wouldn't be setting the icon in Responsys at all. Can you just make Responsys use the FCM / App icon from the AppManifest? |
Hello @neerhaj just checking back in. Any plans to allow Responsys to use the app icon like FCM does? If we don't set the icon in Responsys, it shows up as a white dot. |
We are looking into the possible ways to allow apps to set the smallIcon. We'll get back with an update shortly. |
Our notification icon is an XML resource. As you can see the icon is not scaled correctly and seems to have padding. When used with pure FCM push (no Responsys) the icon appears correctly and at the right size. Also it would be nice if you provided a setIconColor function (for
default_notification_color
) in order to style the icon for when the icon is provided in XML format. When a PNG resource is used, the icon appears correctly in Responsys. So this is an incompatibility with XML icons.Is there a reason you can't use the default icon settings that are already passed to FCM in AndroidManifest?
The native code is as follows:
Responsys:
FCM:
The text was updated successfully, but these errors were encountered: