Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HT-554: Add icon position and custom borders to OXD checkbox component #816

Merged
merged 10 commits into from
Nov 12, 2024
Merged

HT-554: Add icon position and custom borders to OXD checkbox component #816

merged 10 commits into from
Nov 12, 2024

Conversation

Nuwa-Hub
Copy link

@Nuwa-Hub Nuwa-Hub commented Nov 6, 2024 •
edited
Loading

Checklist

  • Test Coverage is 100% for the newly added code
  • Storybook stories are added/updated for the changed areas
  • Components standards defined in this document are followed
  • Code is linted properly
  • Developer testing is done for the affected areas
  • Package version updated (not applicable to ent branch)
  • Changelog.md updated on possible breaking (applicable to ent branch)

@Nuwa-Hub Nuwa-Hub changed the title HT-554:Update OXD CheckBox Component HT-554:Update OXD CheckBox/SelectInput Component Nov 7, 2024
Super-Chama
Super-Chama reviewed Nov 11, 2024
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
Super-Chama
Super-Chama reviewed Nov 12, 2024
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
Super-Chama
Super-Chama reviewed Nov 12, 2024
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
@Super-Chama Super-Chama changed the title HT-554:Update OXD CheckBox/SelectInput Component HT-554: Add icon position and custom borders to OXD checkbox component Nov 12, 2024
@Super-Chama Super-Chama merged commit d435c75 into orangehrm:ent Nov 12, 2024
3 checks passed
inmoh7 pushed a commit to inmoh7/oxd that referenced this pull request Nov 13, 2024
@Nuwa-Hub @inmoh7
HT-554: Add icon position and custom borders to OXD checkbox component (
f01c6fa 
orangehrm#816)

* HT-554:Update OXD CheckBox Components

* HT:554:Updating oxd checkbox and oxd select input components

* HT-554:Update changelog.md file

* HT-554:Fix issues

* HT-554:FIxed lint issues

* HT-554:Fixed unit test & lint issues

* HT-554:fix wording issue

* HT-554:Fix issue in checkbox component and select input story

* HT-554:Update change log file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Super-Chama Super-Chama Super-Chama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuwa-Hub @Super-Chama