-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vote for release of v1.2.5
#697
Comments
LGTM. We need to mention the |
LGTM |
Closing as |
okozachenko1203
added a commit
to vexxhost/atmosphere
that referenced
this issue
Oct 18, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. ``` /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig ``` oras-go is indirect dep belonging to helm.sh/helm/v3. since v3.15.2, helm uses 1.2.5 oras-go. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2
atmosphere-ci bot
pushed a commit
to vexxhost/atmosphere
that referenced
this issue
Oct 21, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go. Btw, I updated helm to v3.16.2. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2
okozachenko1203
added a commit
to vexxhost/atmosphere
that referenced
this issue
Oct 22, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go. Btw, I updated helm to v3.16.2. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2
okozachenko1203
added a commit
to vexxhost/atmosphere
that referenced
this issue
Oct 22, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go. Btw, I updated helm to v3.16.2. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2
This was referenced Oct 22, 2024
okozachenko1203
added a commit
to vexxhost/atmosphere
that referenced
this issue
Oct 22, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go. Btw, I updated helm to v3.16.2. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2
okozachenko1203
added a commit
to vexxhost/atmosphere
that referenced
this issue
Oct 22, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go. Btw, I updated helm to v3.16.2. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2
atmosphere-ci bot
pushed a commit
to vexxhost/atmosphere
that referenced
this issue
Oct 25, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go. Btw, I updated helm to v3.16.2. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2 fix #2002 Depends-On: #2027
atmosphere-ci bot
pushed a commit
to vexxhost/atmosphere
that referenced
this issue
Oct 25, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go. Btw, I updated helm to v3.16.2. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2 fix #2003 Depends-On: #2026
atmosphere-ci bot
pushed a commit
to vexxhost/atmosphere
that referenced
this issue
Oct 25, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go. Btw, I updated helm to v3.16.2. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2 fix #2001 Depends-On: #2028
atmosphere-ci bot
pushed a commit
to vexxhost/atmosphere
that referenced
this issue
Oct 25, 2024
oras-go is the main reason. types.AuthConfig is deprecated in docker v25.x.x. This causes unit test failure. /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go. Btw, I updated helm to v3.16.2. here are references. oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2 fix #2004 Depends-On: #2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At least 3 approvals are needed from the 4 owners for tagging 9d9e2cb from the
v1
branch asv1.2.5
.Aside from the dependency bump-ups, there is one noteworthy change:
types.AuthConfig
is moved toregistry.AuthConfig
indocker/docker v25.0.0
. Although there is no public API change onoras-go
side, it may still break users if they are usingoras-go v1
along with old versions ofdocker/docker
(see fix: get rid of deprecated types.AuthConfig #678).See the change log for more details.
Please respond LGTM or REJECT (with reasoning).
The text was updated successfully, but these errors were encountered: