Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support OCI image layout target in oras manifest delete #762

Closed
qweeah opened this issue Jan 20, 2023 · 7 comments · Fixed by #1197
Closed

support OCI image layout target in oras manifest delete #762

qweeah opened this issue Jan 20, 2023 · 7 comments · Fixed by #1197
Labels
enhancement New feature or request
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Jan 20, 2023

User should be able to use oras manifest delete to remove a manifest in their OCI layout folder with properly garbage collection.

@qweeah qweeah added this to the v1.1.0 milestone Jan 20, 2023
@qweeah qweeah changed the title support OCI image layout target in manifest delete support OCI image layout target in oras manifest delete Jan 20, 2023
@shizhMSFT shizhMSFT added the enhancement New feature or request label Jan 30, 2023
@qweeah qweeah added the good first issue Good for newcomers label Feb 27, 2023
@sidharthviz
Copy link

Hi @qweeah I would like to work on this, Could you assign me for this issue ?

@qweeah
Copy link
Contributor Author

qweeah commented Mar 4, 2023

@sidharthviz Welcome! You might need to start to get familiar with OCI image layout and related oras-go packages. The garbage collection part can be skipped in this issue. It is expected to be done in another command set discussed in #792.

@qweeah
Copy link
Contributor Author

qweeah commented Mar 4, 2023

Hey @sidharthviz I just found that manifest deletion is not implemented on SDK side. I just created a new issue in oras-go to track: oras-project/oras-go#454, which means this issue might take more effort than expected and may not be a good start point to contribute to oras.

Will unassign you and remove the good-first-issue tag, sorry and feel free to choose another one from https://github.com/oras-project/oras/contribute.

@qweeah qweeah removed the good first issue Good for newcomers label Mar 4, 2023
@sidharthviz
Copy link

Hey @sidharthviz I just found that manifest deletion is not implemented on SDK side. I just created a new issue in oras-go to track: oras-project/oras-go#454, which means this issue might take more effort than expected and may not be a good start point to contribute to oras.

Will unassign you and remove the good-first-issue tag, sorry and feel free to choose another one from https://github.com/oras-project/oras/contribute.

It's alright Billy :)

@qweeah
Copy link
Contributor Author

qweeah commented Jun 5, 2023

both this issue and #761 are depending on merging of oras-project/oras-go#470, moving to 1.2.0 mile stone.

@qweeah qweeah modified the milestones: v1.1.0, v1.2.0 Jun 5, 2023
@FeynmanZhou
Copy link
Member

As a project maintainer for CNCF Notary Project, I would like to have this feature in ORAS v1.2.0 since it enables Notation users to delete a signature from an image in OCI image layout. See an example usage in registry: https://notaryproject.dev/docs/user-guides/how-to/manage-signatures/#delete-a-signature-on-an-artifact

@shizhMSFT
Copy link
Contributor

Note that oras manifest delete just delete the manifest. To delete an image cleanly, we need the GC feature (oras-project/oras-go#472).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants