Skip to content

Commit

Permalink
Fixed /users and /password endpoint mappings (#7)
Browse files Browse the repository at this point in the history
* Fixed /users and /password endpoint mappings
* Use smtp fromAddress for both MF_EMAIL_FROM_ADDRESS and MF_EMAIL_FROM_NAME
  • Loading branch information
Stéfano authored Dec 7, 2021
1 parent c363141 commit 73749ae
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion charts/orb/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ name: orb
description: Orb Observability Platform
icon: https://avatars1.githubusercontent.com/u/13207490
type: application
version: 1.0.8
version: 1.0.9
appVersion: "0.9.0"
home: https://getorb.io
sources:
Expand Down
4 changes: 2 additions & 2 deletions charts/orb/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@ spec:
- host: "{{ .Values.ingress.hostname }}"
http:
paths:
- path: /api/v1/(users)
- path: /api/v1/(users/?.*)
pathType: Prefix
backend:
service:
name: {{ .Release.Name }}-users
port:
number: {{ .Values.users.httpPort }}
- path: /api/v1/(password)
- path: /api/v1/(password/?.*)
pathType: Prefix
backend:
service:
Expand Down
2 changes: 1 addition & 1 deletion charts/orb/templates/users-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ spec:
- name: MF_EMAIL_FROM_ADDRESS
value: {{ required "A valid .Values.smtp.fromAddress is required!" .Values.smtp.fromAddress | quote }}
- name: MF_EMAIL_FROM_NAME
value: {{ .Values.smtp.fromName | quote }}
value: {{ required "A valid .Values.smtp.fromAddress is required!" .Values.smtp.fromAddress | quote }}
- name: MF_EMAIL_TEMPLATE
value: "/email.tmpl"
{{- end }}
Expand Down
7 changes: 3 additions & 4 deletions charts/orb/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@ defaults:
natsPort: 4222
jaegerPort: 6831

orb:
smtp:
port: 25
fromName: Orb
smtp:
port: 25
fromName: Orb

ingress:
issuer: "letsencrypt-prod"
Expand Down

0 comments on commit 73749ae

Please sign in to comment.