Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Group Messages Become Direct Messages #12

Open
davidbartonau opened this issue Nov 17, 2018 · 4 comments
Open

Private Group Messages Become Direct Messages #12

davidbartonau opened this issue Nov 17, 2018 · 4 comments

Comments

@davidbartonau
Copy link
Contributor

I have messages in restricted rooms that are converted into direct messages to the user themselves.
The original room was:

  {
    "Room": {
      "created": "2016-03-29T03:48:30+00:00",
      "guest_access_url": null,
      "id": 2588117,
      "is_archived": false,
      "members": [
        3063160
      ],
      "name": "BA Discussion Group",
      "owner": 3063160,
      "participants": [],
      "privacy": "private",
      "topic": ""
    }
  },

The message was:

 {
    "UserMessage": {
      "attachment": null,
      "attachment_path": null,
      "id": "6035b46b-6846-465c-846f-cf49f8c151a4",
      "mentions": [
        3063160,
        3117296
      ],
      "message": "@dave can you giv me and @Sali access to the above document so we can track the issues ther. ",
      "sender": {
        "id": 3074991,
        "links": {
          "self": "https://api.hipchat.com/v2/user/3074991"
        },
        "mention_name": "Insixxx",
        "name": "Insxxx",
        "version": "B6F3C039"
      },
      "timestamp": "2018-11-01T10:38:25Z 135846",
      "type": "user"
    }
  },

And this then becomes a private message. I really don't understand why, but clearly thought has gone into this.

{ "type": "direct_post", "direct_post": { "channel_members": ["insxxx", "insxxx"], "user": "insxxx", "message": "\n\n@dave can you giv me and @Sali access to the above document so we can track the issues ther. ", "create_at": 1541068705000 } } 

I am reversing this for myself to try but I am interested in your feedback @ylluminarious

@davidbartonau
Copy link
Contributor Author

@ylluminarious I have a local revision with that change reversed and it works really well.

@jby
Copy link

jby commented Apr 5, 2019

I'm seeing this as well with master (d887295), any tips on how to get around it?

Thinking it might be because the intended room already existed I tried to import into a different (non-existent) room, but where those messages went I have no earthly idea, the import went through without problem, but no channel/room was created and the messages seems to have gone into cyberspace...

@jby
Copy link

jby commented Apr 15, 2019

Cleaned everything out and went with an updated master of mattermost-docker (mattermost/mattermost-docker@cb6690b), but still I get all messages sent to the imported room ends up as private messages from me to me...

@jby
Copy link

jby commented Apr 15, 2019

It seems to be related to the room/channel type "P", if I try to import a room/channel of type "O" it does what I expect - creates a public room of the data...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants