Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed magnitude range #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Andr0id100
Copy link

For #76 .
Fixes the magnitude range for spectograms as (-200, 100). The range was chosen based on previously generated spectograms.

@Andr0id100
Copy link
Author

Code quality action failure seems to be caused by a version issue with black.

Need to update tests before initiating the test action otherwise it would fail for save_spectogram

@valentina-s
Copy link
Collaborator

Thanks for the addition @Andr0id100. The plot_psd function is a general function, that could be used for different applications, so instead of fixing the bounds of the spectrogram there it is better to pass them as parameters and fix them in the workflow specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants