PHP 8.3 Support Improvements (#10)

* wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> --------- Signed-off-by: Mior Muhammad Zaki <[email protected]>
orchestral · Nov 24, 2023 · 302465f · 302465f
1 parent bd4f154
commit 302465f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/composer.json b/composer.json
@@ -35,9 +35,12 @@
     },
     "require-dev": {
         "laravel/pint": "^1.6",
-        "orchestra/testbench": "^8.13",
+        "laravel/framework": "^10.26",
+        "mockery/mockery": "^1.5.1",
+        "orchestra/testbench-core": "^8.15",
         "phpstan/phpstan": "^1.10.6",
-        "phpunit/phpunit": "^10.1"
+        "phpunit/phpunit": "^10.1",
+        "symfony/yaml": "^6.2"
     },
     "conflict": {
         "orchestra/canvas": "<8.11.0",
@@ -64,9 +67,8 @@
             "@clear",
             "@prepare"
         ],
-        "prepare": "@php vendor/bin/testbench package:discover --ansi",
         "clear": "@php vendor/bin/testbench package:purge-skeleton --ansi",
-        "build": "@php vendor/bin/testbench workbench:build --ansi",
+        "prepare": "@php vendor/bin/testbench package:discover --ansi",
         "lint": [
             "@php vendor/bin/phpstan analyse",
             "@php vendor/bin/pint"
@@ -79,6 +81,5 @@
             "@test"
         ]
     },
-    "prefer-stable": true,
-    "minimum-stability": "dev"
+    "minimum-stability": "stable"
 }
diff --git a/src/Commands/GeneratorCommand.php b/src/Commands/GeneratorCommand.php
@@ -35,6 +35,7 @@ public function __construct(Filesystem $files)
      *
      * @throws \Illuminate\Contracts\Filesystem\FileNotFoundException
      */
+    #[\Override]
     public function handle()
     {
         return $this->generateCode() ? self::SUCCESS : self::FAILURE;
@@ -46,6 +47,7 @@ public function handle()
      * @param  string  $name
      * @return string
      */
+    #[\Override]
     protected function getPath($name)
     {
         return $this->getPathUsingCanvas($name);
@@ -56,6 +58,7 @@ protected function getPath($name)
      *
      * @return string
      */
+    #[\Override]
     protected function qualifyModel(string $model)
     {
         return $this->qualifyModelUsingCanvas($model);
@@ -66,6 +69,7 @@ protected function qualifyModel(string $model)
      *
      * @return string
      */
+    #[\Override]
     protected function rootNamespace()
     {
         return $this->rootNamespaceUsingCanvas();
@@ -76,6 +80,7 @@ protected function rootNamespace()
      *
      * @return string|null
      */
+    #[\Override]
     protected function userProviderModel()
     {
         return $this->userProviderModelUsingCanvas();
@@ -86,6 +91,7 @@ protected function userProviderModel()
      *
      * @return string
      */
+    #[\Override]
     protected function viewPath($path = '')
     {
         return $this->viewPathUsingCanvas($path);
@@ -96,6 +102,7 @@ protected function viewPath($path = '')
      *
      * @return array<int, string>
      */
+    #[\Override]
     protected function possibleModels()
     {
         return $this->possibleModelsUsingCanvas();
@@ -106,6 +113,7 @@ protected function possibleModels()
      *
      * @return array<int, string>
      */
+    #[\Override]
     protected function possibleEvents()
     {
         return $this->possibleEventsUsingCanvas();

diff --git a/src/Commands/MigrationGeneratorCommand.php b/src/Commands/MigrationGeneratorCommand.php
@@ -19,6 +19,7 @@ abstract class MigrationGeneratorCommand extends \Illuminate\Console\MigrationGe
      *
      * @return void
      */
+    #[\Override]
     public function __construct(Filesystem $files, Composer $composer)
     {
         parent::__construct($files, $composer);
@@ -32,6 +33,7 @@ public function __construct(Filesystem $files, Composer $composer)
      * @param  string  $table
      * @return string
      */
+    #[\Override]
     protected function createBaseMigration($table)
     {
         return $this->createBaseMigrationUsingCanvas($table);
@@ -43,6 +45,7 @@ protected function createBaseMigration($table)
      * @param  string  $table
      * @return bool
      */
+    #[\Override]
     protected function migrationExists($table)
     {
         return $this->migrationExistsUsingCanvas($table);