What's the difference between Dismiss stale pull request approvals when new commits are pushed
and Require approval of the most recent reviewable push
branch protection option?
#109549
Replies: 2 comments
-
Helloo 👋🏼 The "require approval of the most recent push" protection rule was introduced in oct 202), with the express purpose to prevent someone responding to a code review request from sneaking in changes and approving them themselves or using the already supplied approval from another reviewer. The security research that explores these topics has not been broadly published, but there are some great discussions with recommendations on how to secure your branches. With the other policy enabled, when a reviewer applies some suggestions to the code, they can't approve and merge the code without finding another person to review their changes. Got this from Stack Overflow -> To access the content, please follow this link: Stack Overflow Question. Hope this helps! 🤞🏼 |
Beta Was this translation helpful? Give feedback.
-
🕒 Discussion Activity Reminder 🕒 This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions: 1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as 2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own. 3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution. Note: This dormant notification will only apply to Discussions with the Thank you for helping bring this Discussion to a resolution! 💬 |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Question
Body
In the branch settings, there are two similar options:
Dismiss stale pull request approvals when new commits are pushed
Require approval of the most recent reviewable push
What's the difference between these two?
When trying out the latter, it still dismisses all the reviews from the users who approved, so I don't really see a difference to the first one and I haven't find a doc explaining what it does exactly.
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions