Reaction button hidden on mobile

[Slion]

Though is shows for my own comments but not on other people's comments. Also if a comment already has some reaction then you can still use the reaction button below the comment. However if a comment is not yours and does not have a reaction already then you can't react to it because the reaction button at the top next to the menu button is not shown.

I feel like this is a regression that was introduced recently.

[michaelblyons]

I sometimes see a reaction button in the header of a comment even when there are no reactions on it, but it is rare, and I have no idea what the pattern for that might be. (Maybe someone reacted and then un-reacted?)

But this is indeed annoying. I would love for this to be fixed.

[genofire]

I just see it, if i am in Desktop vor Desktop-mode in Browser.

[michaelblyons]

I now see it every time, but clicking on it zooms out the whole page so the emoji can load to the right of the content area.

[genofire]

You mean this way? Yes, me too.

[beerisgood]

can confirm this on Safari under iOS 15.4.1.

Screenshot:

[thw0rted]

Are you sure you're looking in the right place? Compare portrait:

to landscape:

[reduckted]

This is what it looks like for me at this comment:

Portrait

Landscape

[thw0rted]

If you keep scrolling for a few comments to one that doesn't have a "member" or "author" tag (i.e. just the overflow menu), is that also missing the reaction button? I'm wondering if, say, portrait has room for one button and landscape has room for two. (I can't get to my phone at the moment, or I'd try it myself.)

[reduckted]

I had the same thought, but no, even if there are no "member" tags the reaction button doesn't show up.

You're right about the CSS, though. I just had a look on desktop, and when resizing the window to 767px wide or less, the reaction button is assigned the d-none class, which equates to display: none !important;.

I guess it may depend on how tall your phone is as to whether it reappears when rotating to landscape mode. Actually, on your landscape screenshot it looks like the right-hand side menu (with the Subscribe button) is visible, which only appeared for me when the screen width was 768px or higher.

[alialhammad1992]

The problem is supposed to be solved from the ground up by supporting the GithHub application

[beerisgood]

Looks like the problem is back on Safari.
no button available

[Slion]

Was it ever really fixed? I think they put the button back but the reaction selector pop-up would break the page layout and cause a zoom out of the page until you pick one reaction.

[BDisp]

To aggravate the situation this problem is also already verified in any browser executed from a laptop. The popup with the buttons appears outside the screen area resulting in some hidden buttons.
Edit:
I only refer to clicking the button located at the bottom of a comment of a pull request, after there has already been a reaction.

[alialhammad1992]

The problem is supposed to be solved from the ground up by supporting the GithHub application

[tmccombs]

This is still an issue for me in Firefox for Android.

[mag122ed]

31387933

[tmccombs]

Interestingly, the emoji button does show up in discussions, and if I am in landscape mode.

[beerisgood]

Today I got this broken popup in iOS Safari:

[ProtoDot]

I would react to this since I don't have anything to add but I can't. 😡

[diegobotelhohm]

<!-- /* Font Definitions */ @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} @font-face {font-family:"Segoe UI Emoji"; panose-1:2 11 5 2 4 2 4 2 2 3;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; font-size:11.0pt; font-family:"Calibri",sans-serif;} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} .MsoChpDefault {mso-style-type:export-only;} @page WordSection1 {size:612.0pt 792.0pt; margin:70.85pt 3.0cm 70.85pt 3.0cm;} div.WordSection1 {page:WordSection1;} -->Você mora no meu coração. Gratidão por tudo Enviado do Email para Windows De: ProtoDotEnviado:segunda-feira, 5 de dezembro de 2022 21:28Para: community/communityCc:SubscribedAssunto: Re: [community/community] Reaction button hidden on mobile (Discussion #12781) I would react to this since I don't have anything to add but I can't. 😡—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> 

[diegobotelhohm]

<!-- /* Font Definitions */ @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} @font-face {font-family:"Segoe UI Emoji"; panose-1:2 11 5 2 4 2 4 2 2 3;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; font-size:11.0pt; font-family:"Calibri",sans-serif;} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} .MsoChpDefault {mso-style-type:export-only;} @page WordSection1 {size:612.0pt 792.0pt; margin:70.85pt 3.0cm 70.85pt 3.0cm;} div.WordSection1 {page:WordSection1;} -->Voce Faz Por Merecer, Basta Querer, Estar Dispoto a se reconhecer, Fazer acontecer, Fazer por você, Voce Pode TUDOOOO, quem faz acontecer e você mesmo, Seja mais leve com você mesmo. E se cobre menos, errar e humano, somos cheios de defeito, Estamos aqui pra aprendermos e sermos melhores.  Enviado do Email para Windows De: ProtoDotEnviado:segunda-feira, 5 de dezembro de 2022 21:28Para: community/communityCc:SubscribedAssunto: Re: [community/community] Reaction button hidden on mobile (Discussion #12781) I would react to this since I don't have anything to add but I can't. 😡—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> 

[telF4]

may be,that is future, laughing.

[xenago]

This is still an issue on Chromium based browsers on Android like Samsung Internet

[marc-guenther]

Still no button on Safari on my iPhone. Neither in portrait nor landscape mode. There is more than enough space available in the upper right. Also nothing in the ... context menu.

There IS a button, if somebody else already reacted to the comment, though. That one is in the lower left, though.

Clearly a company such as Github should be able to place a simple button on a page, without breaking the layout? How hard can it be?

[jefro108]

It appears to be an issue not in the ‘Discussions’ but in the ‘Issues’ section which can’t be seen on this repository. I’m on iPhone iOS 16.2 on Chrome. There are no reaction buttons visible unless someone has already used one in that particular comment.

In ‘Discussions’ the reaction button is always next to the ‘upvote’ button under the comment, but in ‘Issues’ (where there’s no upvote button) it’s in the comment header when there is no previous reaction and doesn’t appear on mobile.

However the reaction button appears in the header of a reply in a ‘Discussion’ (which we can see here) when it’s nested but replies aren’t nested in ‘Issues’.

It would solve the issue if in ‘Issues’ the reactions button was always placed below the comment - which is a more intuitive position anyway!

[BDisp]

@jefro108 why don't you open an issue based on your comment? Copy link and past on a new issue. It seems that the only place to open an issue is in this repo https://github.com/community/OSPO/issues.

[Kaminem202]

Though is shows for my own comments but not on other people's comments. Also if a comment already has some reaction then you can still use the reaction button below the comment. However if a comment is not yours and does not have a reaction already then you can't react to it because the reaction button at the top next to the menu button is not shown.

I feel like this is a regression that was introduced recently.

[ckujau]

This is only the community buffer discussion forum, does anyone know if a GitHub bug exists for this problem?

[tan-wei-xin-alez]

Still happening on iOS Safari 15.1 (tested on comments on PR in private repo with both portrait and landscape mode), doesn’t seem to have an open GitHub issue as of now

[ADTC]

Using Android, and I find this so annoying. I have to enable "Desktop mode" to add the first reaction to a comment.

This affects the Issues section of a repository btw, not Discussions.

[BDisp]

Using Android, and I find this so annoying. I have to enable "Desktop mode" to add the first reaction to a comment.

Where do you enable the "Desktop mode" using Android?

[ADTC]

In Chrome browser in Android, you can open the menu and there will be a checkbox called "Desktop site".

I think other mobile browsers have a similar feature.

[BDisp]

Thanks. I found it. I never realized that option was there :-)

[ADTC]

There's a lot you can discover when you tap and swipe on everything you see on your phone screen ;)

[Djfe]

finally, we have the option now

[Slion]

Only took them about a year to fix it. To be honest I'm fully expecting them to break it again sooner or later 🥳

[rooby]

This seems to be broken again. Using Chrome on iOS.
EDIT: Seems to be working on issues but broken on PRs.

[Djfe]

Working just fine for me on issues as well as prs.
Firefox for Android (117.1.10)

I didn't notice anything broken lately either

[rooby]

Oh, the particular PR I'm looking at won't let me emote even on desktop. Seems to be something about that specific PR.
Apologies for the noise.