Merging a PR with linking keywords no longer closing issues #140003
Replies: 4 comments 1 reply
-
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
For me, this happens sporadically and unpredictably: Sometimes |
Beta Was this translation helpful? Give feedback.
-
The problem still occurs |
Beta Was this translation helpful? Give feedback.
-
I haven't had a problem with "Closes #123", but I just found that |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Bug
Body
While some people actually want this behavior of not closing issues when using linking keywords like "fixes" or "resolves" (see #66741), my team uses it a lot. In the past couple of days, this hasn't been working. I had a couple of PRs with
Fixes #123
orResolves #456
in the PR description - not comments - and they were not closed.The linking keyword is even underlined, but there's no longer a tooltip when you hover like there was before explaining what would happen. The issue also didn't have the PR linked.
One example: Azure/azure-sdk-for-rust#1812
Beta Was this translation helpful? Give feedback.
All reactions