How can I see review comments together with the resulting code changes? #152334
-
Select Topic AreaQuestion BodyThe author made new code changes (in several commits) after I provided review comments on the old code changes. I would like to see in a single view the newest code changes and the (unresolved) review comments that spurred them, so I can most easily tell if and how the new code changes relate to the review comments, and can mark the comments as resolved if they have in fact been resolved. How can I arrange that? In the "Conversations" view of the pull request I can see the review comments (most if not all of them marked as "Outdated") and the snippets of old code that they are associated with, but not the new code changes. In the "Files changed" view I can see before and after states related to the new code changes but then the review comments that led to the code changes aren't visible. I can of course open two GitHub windows, one that shows the old comments and one that shows the new code changes, but then I have to manually find the corresponding items in both views, which is tedious and seems unnecessary because GitHub has all necessary information to perform that task for me and show the results in a single view. |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 6 replies
-
You can also link in the comments if you want to see the conversation in the old code. |
Beta Was this translation helpful? Give feedback.
This is also on the web, I am also a smartphone user (especially).
You cant view changes simultaneously, GitHub doesn't provide this feature. But I gave a solution that "takes you" in the previous commit conversation history.
Before you merge an author pull request, old changes are merged with new changes. So that takes you to the repo she/he forked to see in more detail where the changes are:
I suggest looking at the change history via author's repo forked commits:
In the repo > to the commit **above the file (history clock image)